chrome/browser/android/offline_pages/prerendering_offliner.cc - Issue 2023293002: OfflinePageModel cleanups - improved CanSavePage() and moved static kInvalidOfflineId to impl

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/android/offline_pages/prerendering_offliner.cc

Issue 2023293002: OfflinePageModel cleanups - improved CanSavePage() and moved static kInvalidOfflineId to impl (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: synced Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/android/offline_pages/offline_page_bridge.cc ('k') | chrome/browser/android/offline_pages/recent_tab_helper.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/android/offline_pages/prerendering_offliner.cc

diff --git a/chrome/browser/android/offline_pages/prerendering_offliner.cc b/chrome/browser/android/offline_pages/prerendering_offliner.cc

index fb89eae1f12e66e2303fe12624c4b2f6f1f79440..c7aab9e3f0953753e0a030325936f988c4e0c3fc 100644

--- a/chrome/browser/android/offline_pages/prerendering_offliner.cc

+++ b/chrome/browser/android/offline_pages/prerendering_offliner.cc

@@ -7,6 +7,7 @@

#include "base/bind.h"

#include "chrome/browser/android/offline_pages/offline_page_mhtml_archiver.h"

#include "components/offline_pages/background/save_page_request.h"

+#include "components/offline_pages/offline_page_model.h"

#include "content/public/browser/browser_context.h"

namespace offline_pages {

@@ -106,7 +107,7 @@ bool PrerenderingOffliner::LoadAndSave(const SavePageRequest& request,

return false;

}

- if (!OfflinePageModel::CanSavePage(request.url())) {

+ if (!OfflinePageModel::CanSaveURL(request.url())) {

DVLOG(1) << "Not able to save page for requested url: " << request.url();

return false;

}