Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(384)

Side by Side Diff: chrome/browser/android/offline_pages/prerendering_offliner.cc

Issue 2023293002: OfflinePageModel cleanups - improved CanSavePage() and moved static kInvalidOfflineId to impl (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: synced Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/android/offline_pages/prerendering_offliner.h" 5 #include "chrome/browser/android/offline_pages/prerendering_offliner.h"
6 6
7 #include "base/bind.h" 7 #include "base/bind.h"
8 #include "chrome/browser/android/offline_pages/offline_page_mhtml_archiver.h" 8 #include "chrome/browser/android/offline_pages/offline_page_mhtml_archiver.h"
9 #include "components/offline_pages/background/save_page_request.h" 9 #include "components/offline_pages/background/save_page_request.h"
10 #include "components/offline_pages/offline_page_model.h"
10 #include "content/public/browser/browser_context.h" 11 #include "content/public/browser/browser_context.h"
11 12
12 namespace offline_pages { 13 namespace offline_pages {
13 14
14 PrerenderingOffliner::PrerenderingOffliner( 15 PrerenderingOffliner::PrerenderingOffliner(
15 content::BrowserContext* browser_context, 16 content::BrowserContext* browser_context,
16 const OfflinerPolicy* policy, 17 const OfflinerPolicy* policy,
17 OfflinePageModel* offline_page_model) 18 OfflinePageModel* offline_page_model)
18 : browser_context_(browser_context), 19 : browser_context_(browser_context),
19 offline_page_model_(offline_page_model), 20 offline_page_model_(offline_page_model),
(...skipping 79 matching lines...) Expand 10 before | Expand all | Expand 10 after
99 if (pending_request_) { 100 if (pending_request_) {
100 DVLOG(1) << "Already have pending request"; 101 DVLOG(1) << "Already have pending request";
101 return false; 102 return false;
102 } 103 }
103 104
104 if (!GetOrCreateLoader()->CanPrerender()) { 105 if (!GetOrCreateLoader()->CanPrerender()) {
105 DVLOG(1) << "Prerendering not allowed/configured"; 106 DVLOG(1) << "Prerendering not allowed/configured";
106 return false; 107 return false;
107 } 108 }
108 109
109 if (!OfflinePageModel::CanSavePage(request.url())) { 110 if (!OfflinePageModel::CanSaveURL(request.url())) {
110 DVLOG(1) << "Not able to save page for requested url: " << request.url(); 111 DVLOG(1) << "Not able to save page for requested url: " << request.url();
111 return false; 112 return false;
112 } 113 }
113 114
114 // Track pending request for callback handling. 115 // Track pending request for callback handling.
115 pending_request_ = &request; 116 pending_request_ = &request;
116 117
117 // Kick off load page attempt. 118 // Kick off load page attempt.
118 bool accepted = GetOrCreateLoader()->LoadPage( 119 bool accepted = GetOrCreateLoader()->LoadPage(
119 request.url(), 120 request.url(),
(...skipping 29 matching lines...) Expand all
149 } 150 }
150 151
151 PrerenderingLoader* PrerenderingOffliner::GetOrCreateLoader() { 152 PrerenderingLoader* PrerenderingOffliner::GetOrCreateLoader() {
152 if (!loader_) { 153 if (!loader_) {
153 loader_.reset(new PrerenderingLoader(browser_context_)); 154 loader_.reset(new PrerenderingLoader(browser_context_));
154 } 155 }
155 return loader_.get(); 156 return loader_.get();
156 } 157 }
157 158
158 } // namespace offline_pages 159 } // namespace offline_pages
OLDNEW
« no previous file with comments | « chrome/browser/android/offline_pages/offline_page_bridge.cc ('k') | chrome/browser/android/offline_pages/recent_tab_helper.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698