chrome/browser/android/offline_pages/recent_tab_helper.cc - Issue 2023293002: OfflinePageModel cleanups - improved CanSavePage() and moved static kInvalidOfflineId to impl

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/android/offline_pages/recent_tab_helper.cc

Issue 2023293002: OfflinePageModel cleanups - improved CanSavePage() and moved static kInvalidOfflineId to impl (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/android/offline_pages/offline_page_bridge.cc ('K') | « chrome/browser/android/offline_pages/prerendering_offliner.cc ('k') | components/offline_pages/offline_page_model.h » ('j') | components/offline_pages/offline_page_model_impl.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/android/offline_pages/recent_tab_helper.cc

diff --git a/chrome/browser/android/offline_pages/recent_tab_helper.cc b/chrome/browser/android/offline_pages/recent_tab_helper.cc

index 5eb1a3f1d41b96be993c68614ae159d53bc6510a..ef85629bea9845c1c14492ba427d31a1b07b111c 100644

--- a/chrome/browser/android/offline_pages/recent_tab_helper.cc

+++ b/chrome/browser/android/offline_pages/recent_tab_helper.cc

@@ -16,6 +16,7 @@

#include "base/time/time.h"

#include "chrome/browser/android/offline_pages/offline_page_mhtml_archiver.h"

#include "chrome/browser/android/offline_pages/offline_page_model_factory.h"

+#include "chrome/browser/android/offline_pages/offline_page_utils.h"

#include "components/offline_pages/offline_page_item.h"

#include "components/offline_pages/offline_page_model.h"

#include "content/public/browser/browser_context.h"

@@ -92,7 +93,7 @@ void RecentTabHelper::StartSnapshot() {

return;

GURL url = web_contents()->GetLastCommittedURL();

- bool can_save = page_model_->CanSavePage(url);

+ bool can_save = OfflinePageUtils::CanSaveURL(url);

UMA_HISTOGRAM_BOOLEAN("OfflinePages.CanSaveRecentPage", can_save);

if (!can_save)

return;