Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(298)

Unified Diff: chrome/browser/android/offline_pages/prerendering_offliner.cc

Issue 2023293002: OfflinePageModel cleanups - improved CanSavePage() and moved static kInvalidOfflineId to impl (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/android/offline_pages/prerendering_offliner.cc
diff --git a/chrome/browser/android/offline_pages/prerendering_offliner.cc b/chrome/browser/android/offline_pages/prerendering_offliner.cc
index d873b02238b9a17c4a0767c5a36af87a1fa09a74..005d5f2c4e0cd010780bdee0782e1e702bf4e8c9 100644
--- a/chrome/browser/android/offline_pages/prerendering_offliner.cc
+++ b/chrome/browser/android/offline_pages/prerendering_offliner.cc
@@ -6,6 +6,7 @@
#include "base/bind.h"
#include "chrome/browser/android/offline_pages/offline_page_mhtml_archiver.h"
+#include "chrome/browser/android/offline_pages/offline_page_utils.h"
#include "components/offline_pages/background/save_page_request.h"
#include "content/public/browser/browser_context.h"
@@ -101,7 +102,7 @@ bool PrerenderingOffliner::LoadAndSave(const SavePageRequest& request,
return false;
}
- if (!CanSavePage(request.url())) {
+ if (!OfflinePageUtils::CanSaveURL(request.url())) {
DVLOG(1) << "Not able to save page";
return false;
}
@@ -134,15 +135,6 @@ void PrerenderingOffliner::SetLoaderForTesting(
loader_ = std::move(loader);
}
-bool PrerenderingOffliner::CanSavePage(const GURL& url) {
- if (!offline_page_model_) {
- // Assume we can save if no OfflinePageModel (for unit tests).
- // TODO(dougarnett): Make OfflinePageModel::CanSavePage() mockable for test.
- return true;
- }
- return offline_page_model_->CanSavePage(url);
-}
-
void PrerenderingOffliner::SavePage(
const GURL& url,
const ClientId& client_id,

Powered by Google App Engine
This is Rietveld 408576698