Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(60)

Issue 2023143002: Blink Compositor Animation: Erase CompositorAnimationsImpl.h (Closed)

Created:
4 years, 6 months ago by loyso (OOO)
Modified:
4 years, 6 months ago
CC:
darktears, blink-reviews, blink-reviews-animation_chromium.org, chromium-reviews, Eric Willigers, rjwright, shans
Base URL:
https://chromium.googlesource.com/chromium/src.git@gmock
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Blink Compositor Animation: Erase CompositorAnimationsImpl.h Make CompositorAnimations class STATIC_ONLY. BUG=577016 Committed: https://crrev.com/b56bbaad735742d2495bea1e5c9836d96f563e38 Cr-Commit-Position: refs/heads/master@{#397615}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+57 lines, -146 lines) Patch
M third_party/WebKit/Source/core/animation/AnimationStack.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/animation/CompositorAnimations.h View 1 chunk +24 lines, -17 lines 0 comments Download
M third_party/WebKit/Source/core/animation/CompositorAnimations.cpp View 10 chunks +15 lines, -32 lines 0 comments Download
D third_party/WebKit/Source/core/animation/CompositorAnimationsImpl.h View 1 chunk +0 lines, -77 lines 0 comments Download
M third_party/WebKit/Source/core/animation/CompositorAnimationsTest.cpp View 7 chunks +9 lines, -10 lines 0 comments Download
M third_party/WebKit/Source/core/animation/KeyframeEffect.cpp View 6 chunks +8 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/core/core.gypi View 1 chunk +0 lines, -1 line 0 comments Download

Depends on Patchset:

Messages

Total messages: 16 (8 generated)
loyso (OOO)
vollick@, could you review jsut core.gypi please?
4 years, 6 months ago (2016-06-01 01:24:32 UTC) #4
Ian Vollick
On 2016/06/01 01:24:32, loyso wrote: > vollick@, could you review jsut core.gypi please? lgtm
4 years, 6 months ago (2016-06-01 01:30:36 UTC) #5
alancutter (OOO until 2018)
lgtm
4 years, 6 months ago (2016-06-02 04:03:41 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2023143002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2023143002/1
4 years, 6 months ago (2016-06-03 00:22:37 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: android_compile_dbg on tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_compile_dbg/builds/76036) cast_shell_android on tryserver.chromium.android (JOB_FAILED, ...
4 years, 6 months ago (2016-06-03 00:31:13 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2023143002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2023143002/1
4 years, 6 months ago (2016-06-03 00:54:55 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-03 03:25:41 UTC) #14
commit-bot: I haz the power
4 years, 6 months ago (2016-06-03 03:27:38 UTC) #16
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b56bbaad735742d2495bea1e5c9836d96f563e38
Cr-Commit-Position: refs/heads/master@{#397615}

Powered by Google App Engine
This is Rietveld 408576698