Add a date/details link to FileError deprecation warning

Add a date/details link to FileError deprecation warning

Intent: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/kJMa2rpAYqI
Dashboard: https://www.chromestatus.com/feature/6687420359639040

R=foolip@chromium.org
BUG=496901
Committed: https://crrev.com/2453b25969a3f6013a473cb35ff85c68580a8db0
Cr-Commit-Position: refs/heads/master@{#405230}

[jsbell, 2016-06-02 17:35:09]

The CQ bit was checked by jsbell@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-06-02 17:35:43]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2023123002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2023123002/1

[commit-bot: I haz the power, 2016-06-02 23:20:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-02 23:20:08]

Dry run: This issue passed the CQ dry run.

[jsbell, 2016-06-02 23:23:25]

FYI, I want to get a CL together for actually removing FileError before landing
this.

It's proving to be tricky because of the internal use of the type for passing
errors around, storing it during sync and async operations, etc. I'm still
pondering the right place to make the change.

[foolip, 2016-06-03 06:48:47]

lgtm

https://codereview.chromium.org/2023123002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/frame/Deprecation.cpp (right):

https://codereview.chromium.org/2023123002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/frame/Deprecation.cpp:181: return
String::format("'FileError is deprecated and will be removed in %s. Please use
the 'name' or 'message' attributes of the error rather than 'code'. See
https://www.chromestatus.com/features/%s for more details.",
milestoneString(53), "6687420359639040");
You can merge 6687420359639040 into the first string.

[jsbell, 2016-07-13 17:19:35]

Description was changed from

==========
Add a date/details link to FileError deprecation warning

R=foolip@chromium.org
BUG=496901
==========

to

==========
Add a date/details link to FileError deprecation warning

Intent:
https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/kJMa2rpAYqI
Dashboard: https://www.chromestatus.com/feature/6687420359639040

R=foolip@chromium.org
BUG=496901
==========

[jsbell, 2016-07-13 17:20:03]

The CQ bit was checked by jsbell@chromium.org

[jsbell, 2016-07-13 17:20:04]

The patchset sent to the CQ was uploaded after l-g-t-m from foolip@chromium.org
Link to the patchset: https://codereview.chromium.org/2023123002/#ps40001
(title: "Bump milestone to 54")

[jsbell, 2016-07-13 17:20:26]

https://codereview.chromium.org/2023123002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/frame/Deprecation.cpp (right):

https://codereview.chromium.org/2023123002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/frame/Deprecation.cpp:181: return
String::format("'FileError is deprecated and will be removed in %s. Please use
the 'name' or 'message' attributes of the error rather than 'code'. See
https://www.chromestatus.com/features/%s for more details.",
milestoneString(53), "6687420359639040");
On 2016/06/03 06:48:46, foolip wrote:
> You can merge 6687420359639040 into the first string.

Done.

[commit-bot: I haz the power, 2016-07-13 17:20:50]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-13 19:44:18]

Description was changed from

==========
Add a date/details link to FileError deprecation warning

Intent:
https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/kJMa2rpAYqI
Dashboard: https://www.chromestatus.com/feature/6687420359639040

R=foolip@chromium.org
BUG=496901
==========

to

==========
Add a date/details link to FileError deprecation warning

Intent:
https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/kJMa2rpAYqI
Dashboard: https://www.chromestatus.com/feature/6687420359639040

R=foolip@chromium.org
BUG=496901
==========

[commit-bot: I haz the power, 2016-07-13 19:44:20]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-07-13 19:45:13]

CQ bit was unchecked.

[commit-bot: I haz the power, 2016-07-13 19:47:25]

Description was changed from

==========
Add a date/details link to FileError deprecation warning

Intent:
https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/kJMa2rpAYqI
Dashboard: https://www.chromestatus.com/feature/6687420359639040

R=foolip@chromium.org
BUG=496901
==========

to

==========
Add a date/details link to FileError deprecation warning

Intent:
https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/kJMa2rpAYqI
Dashboard: https://www.chromestatus.com/feature/6687420359639040

R=foolip@chromium.org
BUG=496901

Committed: https://crrev.com/2453b25969a3f6013a473cb35ff85c68580a8db0
Cr-Commit-Position: refs/heads/master@{#405230}
==========

[commit-bot: I haz the power, 2016-07-13 19:47:26]

Patchset 3 (id:??) landed as
https://crrev.com/2453b25969a3f6013a473cb35ff85c68580a8db0
Cr-Commit-Position: refs/heads/master@{#405230}