Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(55)

Side by Side Diff: third_party/WebKit/Source/core/frame/Deprecation.cpp

Issue 2023123002: Add a date/details link to FileError deprecation warning (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "core/frame/Deprecation.h" 5 #include "core/frame/Deprecation.h"
6 6
7 #include "core/dom/Document.h" 7 #include "core/dom/Document.h"
8 #include "core/dom/ExecutionContext.h" 8 #include "core/dom/ExecutionContext.h"
9 #include "core/frame/FrameConsole.h" 9 #include "core/frame/FrameConsole.h"
10 #include "core/frame/FrameHost.h" 10 #include "core/frame/FrameHost.h"
(...skipping 160 matching lines...) Expand 10 before | Expand all | Expand 10 after
171 { 171 {
172 switch (feature) { 172 switch (feature) {
173 // Quota 173 // Quota
174 case UseCounter::PrefixedStorageInfo: 174 case UseCounter::PrefixedStorageInfo:
175 return replacedBy("'window.webkitStorageInfo'", "'navigator.webkitTempor aryStorage' or 'navigator.webkitPersistentStorage'"); 175 return replacedBy("'window.webkitStorageInfo'", "'navigator.webkitTempor aryStorage' or 'navigator.webkitPersistentStorage'");
176 176
177 case UseCounter::ConsoleMarkTimeline: 177 case UseCounter::ConsoleMarkTimeline:
178 return replacedBy("'console.markTimeline'", "'console.timeStamp'"); 178 return replacedBy("'console.markTimeline'", "'console.timeStamp'");
179 179
180 case UseCounter::FileError: 180 case UseCounter::FileError:
181 return "FileError is deprecated. Please use the 'name' or 'message' attr ibutes of DOMError rather than 'code'."; 181 return String::format("'FileError is deprecated and will be removed in % s. Please use the 'name' or 'message' attributes of the error rather than 'code' . See https://www.chromestatus.com/features/%s for more details.", milestoneStri ng(53), "6687420359639040");
foolip 2016/06/03 06:48:46 You can merge 6687420359639040 into the first stri
jsbell 2016/07/13 17:20:26 Done.
182 182
183 case UseCounter::CSSStyleSheetInsertRuleOptionalArg: 183 case UseCounter::CSSStyleSheetInsertRuleOptionalArg:
184 return "Calling CSSStyleSheet.insertRule() with one argument is deprecat ed. Please pass the index argument as well: insertRule(x, 0)."; 184 return "Calling CSSStyleSheet.insertRule() with one argument is deprecat ed. Please pass the index argument as well: insertRule(x, 0).";
185 185
186 case UseCounter::PrefixedVideoSupportsFullscreen: 186 case UseCounter::PrefixedVideoSupportsFullscreen:
187 return replacedBy("'HTMLVideoElement.webkitSupportsFullscreen'", "'Docum ent.fullscreenEnabled'"); 187 return replacedBy("'HTMLVideoElement.webkitSupportsFullscreen'", "'Docum ent.fullscreenEnabled'");
188 188
189 case UseCounter::PrefixedVideoDisplayingFullscreen: 189 case UseCounter::PrefixedVideoDisplayingFullscreen:
190 return replacedBy("'HTMLVideoElement.webkitDisplayingFullscreen'", "'Doc ument.fullscreenElement'"); 190 return replacedBy("'HTMLVideoElement.webkitDisplayingFullscreen'", "'Doc ument.fullscreenElement'");
191 191
(...skipping 210 matching lines...) Expand 10 before | Expand all | Expand 10 after
402 case UseCounter::TouchEndDuringScrollUserGestureUtilized: 402 case UseCounter::TouchEndDuringScrollUserGestureUtilized:
403 return willBeRemoved("Performing operations that require explicit user i nteraction on touchend events that occur as part of a scroll", 54, "564987125196 3904"); 403 return willBeRemoved("Performing operations that require explicit user i nteraction on touchend events that occur as part of a scroll", 54, "564987125196 3904");
404 404
405 // Features that aren't deprecated don't have a deprecation message. 405 // Features that aren't deprecated don't have a deprecation message.
406 default: 406 default:
407 return String(); 407 return String();
408 } 408 }
409 } 409 }
410 410
411 } // namespace blink 411 } // namespace blink
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698