Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1307)

Unified Diff: build/download_gold_plugin.py

Issue 2023073002: Remove stderr redirect hack from build/download_gold_plugin.py. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/download_gold_plugin.py
diff --git a/build/download_gold_plugin.py b/build/download_gold_plugin.py
index d4fb48b2f475503041b0b780305fd40b0904c995..8123167806dda450bb9e2e3685253ca60435a2a3 100755
--- a/build/download_gold_plugin.py
+++ b/build/download_gold_plugin.py
@@ -34,13 +34,8 @@ def main():
os.chdir(LLVM_BUILD_PATH)
- # TODO(pcc): Fix gsutil.py cp url file < /dev/null 2>&0
- # (currently aborts with exit code 1,
- # https://github.com/GoogleCloudPlatform/gsutil/issues/289) or change the
- # stdin->stderr redirect in update.py to do something else (crbug.com/494442).
subprocess.check_call(['python', GSUTIL_PATH,
- 'cp', remote_path, targz_name],
- stderr=open('/dev/null', 'w'))
+ 'cp', remote_path, targz_name])
subprocess.check_call(['tar', 'xzf', targz_name])
os.remove(targz_name)
return 0
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698