Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Side by Side Diff: build/download_gold_plugin.py

Issue 2023073002: Remove stderr redirect hack from build/download_gold_plugin.py. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 #!/usr/bin/env python 1 #!/usr/bin/env python
2 # Copyright 2015 The Chromium Authors. All rights reserved. 2 # Copyright 2015 The Chromium Authors. All rights reserved.
3 # Use of this source code is governed by a BSD-style license that can be 3 # Use of this source code is governed by a BSD-style license that can be
4 # found in the LICENSE file. 4 # found in the LICENSE file.
5 5
6 """Script to download LLVM gold plugin from google storage.""" 6 """Script to download LLVM gold plugin from google storage."""
7 7
8 import find_depot_tools 8 import find_depot_tools
9 import json 9 import json
10 import os 10 import os
(...skipping 16 matching lines...) Expand all
27 CLANG_REVISION = os.popen(CLANG_UPDATE_PY + ' --print-revision').read().rstrip() 27 CLANG_REVISION = os.popen(CLANG_UPDATE_PY + ' --print-revision').read().rstrip()
28 28
29 CLANG_BUCKET = 'gs://chromium-browser-clang/Linux_x64' 29 CLANG_BUCKET = 'gs://chromium-browser-clang/Linux_x64'
30 30
31 def main(): 31 def main():
32 targz_name = 'llvmgold-%s.tgz' % CLANG_REVISION 32 targz_name = 'llvmgold-%s.tgz' % CLANG_REVISION
33 remote_path = '%s/%s' % (CLANG_BUCKET, targz_name) 33 remote_path = '%s/%s' % (CLANG_BUCKET, targz_name)
34 34
35 os.chdir(LLVM_BUILD_PATH) 35 os.chdir(LLVM_BUILD_PATH)
36 36
37 # TODO(pcc): Fix gsutil.py cp url file < /dev/null 2>&0
38 # (currently aborts with exit code 1,
39 # https://github.com/GoogleCloudPlatform/gsutil/issues/289) or change the
40 # stdin->stderr redirect in update.py to do something else (crbug.com/494442).
41 subprocess.check_call(['python', GSUTIL_PATH, 37 subprocess.check_call(['python', GSUTIL_PATH,
42 'cp', remote_path, targz_name], 38 'cp', remote_path, targz_name])
43 stderr=open('/dev/null', 'w'))
44 subprocess.check_call(['tar', 'xzf', targz_name]) 39 subprocess.check_call(['tar', 'xzf', targz_name])
45 os.remove(targz_name) 40 os.remove(targz_name)
46 return 0 41 return 0
47 42
48 if __name__ == '__main__': 43 if __name__ == '__main__':
49 sys.exit(main()) 44 sys.exit(main())
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698