Fix driver_tools.py to handle the case when command file is empty.

Fix driver_tools.py to handle the case when command file is empty.

ParseArgsBase() was throwing an error when expanding an empty
command file in the end of arguments list. See
https://groups.google.com/a/chromium.org/d/msg/gn-dev/4J_7oC840ds/qtHqyRLmBQAJ

Committed: https://chromium.googlesource.com/native_client/src/native_client/+/2eeb54c6995817a39e5c5cc0b40e26518396335f

[Sergey Ulanov, 2016-06-17 18:42:16]

sergeyu@chromium.org changed reviewers:
+ mseaborn@chromium.org

[Sergey Ulanov, 2016-06-17 18:57:04]

Description was changed from

==========
Fix driver_tools.py to handle the case when command file is empty.

ParseArgsBase() was throwing an error when expanding an empty
command file in the list of arguments. See
https://groups.google.com/a/chromium.org/d/msg/gn-dev/4J_7oC840ds/qtHqyRLmBQAJ
==========

to

==========
Fix driver_tools.py to handle the case when command file is empty.

ParseArgsBase() was throwing an error when expanding an empty
command file in the end of arguments list. See
https://groups.google.com/a/chromium.org/d/msg/gn-dev/4J_7oC840ds/qtHqyRLmBQAJ
==========

[Mark Seaborn, 2016-06-17 19:00:58]

LGTM

[Sergey Ulanov, 2016-06-17 19:02:25]

The CQ bit was checked by sergeyu@chromium.org

[commit-bot: I haz the power, 2016-06-17 19:02:29]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2076883004/1

[commit-bot: I haz the power, 2016-06-17 19:51:53]

Description was changed from

==========
Fix driver_tools.py to handle the case when command file is empty.

ParseArgsBase() was throwing an error when expanding an empty
command file in the end of arguments list. See
https://groups.google.com/a/chromium.org/d/msg/gn-dev/4J_7oC840ds/qtHqyRLmBQAJ
==========

to

==========
Fix driver_tools.py to handle the case when command file is empty.

ParseArgsBase() was throwing an error when expanding an empty
command file in the end of arguments list. See
https://groups.google.com/a/chromium.org/d/msg/gn-dev/4J_7oC840ds/qtHqyRLmBQAJ

Committed:
https://chromium.googlesource.com/native_client/src/native_client/+/2eeb54c69...
==========

[commit-bot: I haz the power, 2016-06-17 19:51:54]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/native_client/src/native_client/+/2eeb54c69...

[kjellander_chromium, 2016-06-20 05:56:07]

On 2016/06/17 19:51:54, commit-bot: I haz the power wrote:
> Committed patchset #1 (id:1) as
>
https://chromium.googlesource.com/native_client/src/native_client/+/2eeb54c69...

I see this change has been rolled into src/native_client via DEPS already, but
it seems it needs to be included in a new toolchain package to affect the build
problem I have in https://codereview.chromium.org/2022833002/. 
How long does it normally take until that happens, or is it a completely manual
process to update that?

[Mark Seaborn, 2016-06-20 19:29:46]

On 19 June 2016 at 22:56, <kjellander@chromium.org> wrote:

> On 2016/06/17 19:51:54, commit-bot: I haz the power wrote:
> > Committed patchset #1 (id:1) as
> >
>
>
https://chromium.googlesource.com/native_client/src/native_client/+/2eeb54c69...
>
> I see this change has been rolled into src/native_client via DEPS already,
> but
> it seems it needs to be included in a new toolchain package to affect the
> build
> problem I have in https://codereview.chromium.org/2022833002/.
> How long does it normally take until that happens, or is it a completely
> manual
> process to update that?
>

You'll need to run build/update_pnacl_tool_revisions.py from native_client/
to update the toolchain.

Cheers,
Mark

-- 
You received this message because you are subscribed to the Google Groups
"Native-Client-Reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to native-client-reviews+unsubscribe@googlegroups.com.
To post to this group, send email to native-client-reviews@googlegroups.com.
Visit this group at https://groups.google.com/group/native-client-reviews.
For more options, visit https://groups.google.com/d/optout.