Allow overridding "app_name" for "test" template on iOS.

Allow overridding "app_name" for "test" template on iOS.

Some downstream iOS unit tests requires the value of BUNDLE_ID_TEST_NAME
to correspond to the target name without any underscore, so let client
override the value of app_name until gyp support is dropped and the tests
can use the target name for value of BUNDLE_ID_TEST_NAME.

BUG=604692
Committed: https://crrev.com/a828c28077a28e859df22109a4fd5630dc94c10f
Cr-Commit-Position: refs/heads/master@{#396746}

[sdefresne, 2016-05-30 16:07:59]

sdefresne@chromium.org changed reviewers:
+ phajdan.jr@chromium.org

[sdefresne, 2016-05-30 16:07:59]

Please take a look and send to CQ if LGTY.

[Paweł Hajdan Jr., 2016-05-30 16:18:59]

LGTM w/nit

https://codereview.chromium.org/2022813002/diff/1/testing/test.gni
File testing/test.gni (right):

https://codereview.chromium.org/2022813002/diff/1/testing/test.gni#newcode304
testing/test.gni:304: if (!defined(invoker.app_name)) {
nit: To avoid double negation, how about reversing the branches, i.e. "if
(defined(invoker.app_name)) app_name = invoker.app_name else ..."?

[sdefresne, 2016-05-30 16:28:37]

Thank you for the review.

https://codereview.chromium.org/2022813002/diff/1/testing/test.gni
File testing/test.gni (right):

https://codereview.chromium.org/2022813002/diff/1/testing/test.gni#newcode304
testing/test.gni:304: if (!defined(invoker.app_name)) {
On 2016/05/30 16:18:59, Paweł Hajdan Jr. wrote:
> nit: To avoid double negation, how about reversing the branches, i.e. "if
> (defined(invoker.app_name)) app_name = invoker.app_name else ..."?

Done.

[sdefresne, 2016-05-30 16:28:51]

The CQ bit was checked by sdefresne@chromium.org

[sdefresne, 2016-05-30 16:28:51]

The patchset sent to the CQ was uploaded after l-g-t-m from
phajdan.jr@chromium.org
Link to the patchset: https://codereview.chromium.org/2022813002/#ps20001
(title: "Flip the conditional")

[commit-bot: I haz the power, 2016-05-30 16:29:02]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2022813002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2022813002/20001

[commit-bot: I haz the power, 2016-05-30 18:04:31]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-05-30 18:05:40]

Description was changed from

==========
Allow overridding "app_name" for "test" template on iOS.

Some downstream iOS unit tests requires the value of BUNDLE_ID_TEST_NAME
to correspond to the target name without any underscore, so let client
override the value of app_name until gyp support is dropped and the tests
can use the target name for value of BUNDLE_ID_TEST_NAME.

BUG=604692
==========

to

==========
Allow overridding "app_name" for "test" template on iOS.

Some downstream iOS unit tests requires the value of BUNDLE_ID_TEST_NAME
to correspond to the target name without any underscore, so let client
override the value of app_name until gyp support is dropped and the tests
can use the target name for value of BUNDLE_ID_TEST_NAME.

BUG=604692

Committed: https://crrev.com/a828c28077a28e859df22109a4fd5630dc94c10f
Cr-Commit-Position: refs/heads/master@{#396746}
==========

[commit-bot: I haz the power, 2016-05-30 18:05:41]

Patchset 2 (id:??) landed as
https://crrev.com/a828c28077a28e859df22109a4fd5630dc94c10f
Cr-Commit-Position: refs/heads/master@{#396746}