Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1340)

Unified Diff: testing/test.gni

Issue 2022813002: Allow overridding "app_name" for "test" template on iOS. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@{2}
Patch Set: Flip the conditional Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: testing/test.gni
diff --git a/testing/test.gni b/testing/test.gni
index bfebe5ffecee18a153fe9708b86fd53e91947ef7..53e84153aebdaacfb201d3401645399db0ec4c9d 100644
--- a/testing/test.gni
+++ b/testing/test.gni
@@ -295,10 +295,18 @@ template("test") {
# TODO: Make this configurable and only provide a default that can be
# overridden.
info_plist = "//testing/gtest_ios/unittest-Info.plist"
- app_name = target_name
entitlements_path = "//testing/gtest_ios"
code_signing_identity = ""
testonly = true
+
+ # TODO(crbug.com/603102): remove this once gyp support is dropped and all
+ # application uses the target name as value for BUNDLE_ID_TEST_NAME.
+ if (defined(invoker.app_name)) {
+ app_name = invoker.app_name
+ } else {
+ app_name = target_name
+ }
+
extra_substitutions = [ "BUNDLE_ID_TEST_NAME=$app_name" ]
# See above call.
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698