chrome/chrome_common.gypi - Issue 2022413002: Convert startup_metric_utils to use mojo.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/chrome_common.gypi

Issue 2022413002: Convert startup_metric_utils to use mojo. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@message-mojom-magic

Patch Set: Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/chrome_common.gypi

diff --git a/chrome/chrome_common.gypi b/chrome/chrome_common.gypi

index 196c2179ac74e743baa241e54c0bec77a1dabaa4..ae8249dd047c3aec5309f3c0eeff81d3e27c061b 100644

--- a/chrome/chrome_common.gypi

+++ b/chrome/chrome_common.gypi

@@ -345,9 +345,6 @@

'<(DEPTH)/components/components.gyp:omnibox_common',

'<(DEPTH)/components/components.gyp:policy',

'<(DEPTH)/components/components.gyp:policy_component_common',

- # TODO(fdoray): Remove this once the PreRead field trial has expired.

- # crbug.com/577698

- '<(DEPTH)/components/components.gyp:startup_metric_utils_common',

'<(DEPTH)/components/components.gyp:translate_core_common',

'<(DEPTH)/components/components.gyp:variations',

'<(DEPTH)/components/components.gyp:version_info',

@@ -514,6 +511,9 @@

'dependencies': [

'<(DEPTH)/components/components.gyp:dom_distiller_core', # Needed by chrome_content_client.cc.

+ # TODO(fdoray): Remove this once the PreRead field trial has

+ # expired. crbug.com/577698

+ '<(DEPTH)/components/components.gyp:startup_metric_utils_common',

erikchen 2016/06/07 16:01:37 why do we need this on win, but not other OSes?

Sam McNally 2016/06/08 00:31:44 startup_metric_utils_common used to contain the me

'all_dependent_settings': {

'msvs_settings': {

« no previous file with comments | « chrome/chrome_browser.gypi ('k') | chrome/chrome_renderer.gypi » ('j') | no next file with comments »