Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(75)

Issue 2022383002: Keep using the same DPI scale (Closed)

Created:
4 years, 6 months ago by oshima
Modified:
4 years, 6 months ago
CC:
chromium-reviews, Tom Anderson
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Keep using the same DPI scale * Dynamic DSF change is not supported/tested on linux. Jus make sure that it uses the same scale unless restarted. BUG=615353 R=thomasanderson@chromium.org Committed: https://crrev.com/52c96f45954fb726585acd0bac295d801728b22e Cr-Commit-Position: refs/heads/master@{#397171}

Patch Set 1 : #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -7 lines) Patch
M chrome/browser/ui/libgtk2ui/gtk2_ui.cc View 1 chunk +19 lines, -7 lines 1 comment Download

Messages

Total messages: 19 (11 generated)
oshima
4 years, 6 months ago (2016-06-01 01:44:02 UTC) #6
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2022383002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2022383002/80001
4 years, 6 months ago (2016-06-01 01:44:28 UTC) #9
Tom (Use chromium acct)
lgtm
4 years, 6 months ago (2016-06-01 01:48:19 UTC) #10
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 6 months ago (2016-06-01 03:27:29 UTC) #12
Elliot Glaysher
lgtm https://codereview.chromium.org/2022383002/diff/80001/chrome/browser/ui/libgtk2ui/gtk2_ui.cc File chrome/browser/ui/libgtk2ui/gtk2_ui.cc (right): https://codereview.chromium.org/2022383002/diff/80001/chrome/browser/ui/libgtk2ui/gtk2_ui.cc#newcode435 chrome/browser/ui/libgtk2ui/gtk2_ui.cc:435: // Keep using the first value detected. I ...
4 years, 6 months ago (2016-06-01 17:22:43 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2022383002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2022383002/80001
4 years, 6 months ago (2016-06-01 17:26:04 UTC) #15
commit-bot: I haz the power
Committed patchset #1 (id:80001)
4 years, 6 months ago (2016-06-01 17:30:40 UTC) #17
commit-bot: I haz the power
4 years, 6 months ago (2016-06-01 17:31:59 UTC) #19
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/52c96f45954fb726585acd0bac295d801728b22e
Cr-Commit-Position: refs/heads/master@{#397171}

Powered by Google App Engine
This is Rietveld 408576698