Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(334)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2022223002: Disable flaky TabindexSaveFileDialog/FileManagerBrowserTest. (Closed)

Created:
4 years, 6 months ago by oka
Modified:
4 years, 6 months ago
Reviewers:
fukino
CC:
chromium-reviews, rginda+watch_chromium.org, oshima+watch_chromium.org, davemoore+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Disable flaky TabindexSaveFileDialog/FileManagerBrowserTest. BUG=615259 Committed: https://crrev.com/5d5d4e478840619dbc9dbfa704aa7ec155a162b9 Cr-Commit-Position: refs/heads/master@{#397028}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Resolve comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M chrome/browser/chromeos/file_manager/file_manager_browsertest.cc View 1 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 11 (4 generated)
oka
PTAL
4 years, 6 months ago (2016-05-31 17:33:16 UTC) #2
fukino
lgtm with a nit https://codereview.chromium.org/2022223002/diff/1/chrome/browser/chromeos/file_manager/file_manager_browsertest.cc File chrome/browser/chromeos/file_manager/file_manager_browsertest.cc (right): https://codereview.chromium.org/2022223002/diff/1/chrome/browser/chromeos/file_manager/file_manager_browsertest.cc#newcode486 chrome/browser/chromeos/file_manager/file_manager_browsertest.cc:486: DISABLED_TabindexSaveFileDialog, Please add a reference ...
4 years, 6 months ago (2016-06-01 00:44:23 UTC) #3
oka
Resolve comment
4 years, 6 months ago (2016-06-01 01:13:06 UTC) #4
oka
4 years, 6 months ago (2016-06-01 01:13:33 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2022223002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2022223002/20001
4 years, 6 months ago (2016-06-01 01:14:10 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 6 months ago (2016-06-01 02:33:38 UTC) #9
commit-bot: I haz the power
4 years, 6 months ago (2016-06-01 02:34:52 UTC) #11
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/5d5d4e478840619dbc9dbfa704aa7ec155a162b9
Cr-Commit-Position: refs/heads/master@{#397028}

Powered by Google App Engine
This is Rietveld 408576698