Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(557)

Side by Side Diff: chrome/browser/chromeos/file_manager/file_manager_browsertest.cc

Issue 2022223002: Disable flaky TabindexSaveFileDialog/FileManagerBrowserTest. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Resolve comment Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2013 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include <stddef.h> 5 #include <stddef.h>
6 6
7 #include "base/macros.h" 7 #include "base/macros.h"
8 #include "base/strings/utf_string_conversions.h" 8 #include "base/strings/utf_string_conversions.h"
9 #include "chrome/browser/chromeos/drive/file_system_util.h" 9 #include "chrome/browser/chromeos/drive/file_system_util.h"
10 #include "chrome/browser/chromeos/file_manager/file_manager_browsertest_base.h" 10 #include "chrome/browser/chromeos/file_manager/file_manager_browsertest_base.h"
(...skipping 464 matching lines...) Expand 10 before | Expand all | Expand 10 after
475 TestParameter(NOT_IN_GUEST_MODE, "tabindexOpenDialogDrive"), 475 TestParameter(NOT_IN_GUEST_MODE, "tabindexOpenDialogDrive"),
476 TestParameter(NOT_IN_GUEST_MODE, "tabindexOpenDialogDownloads"), 476 TestParameter(NOT_IN_GUEST_MODE, "tabindexOpenDialogDownloads"),
477 TestParameter(IN_GUEST_MODE, "tabindexOpenDialogDownloads"))); 477 TestParameter(IN_GUEST_MODE, "tabindexOpenDialogDownloads")));
478 478
479 // Fails on official build. http://crbug.com/482121. 479 // Fails on official build. http://crbug.com/482121.
480 #if defined(DISABLE_SLOW_FILESAPP_TESTS) || defined(OFFICIAL_BUILD) 480 #if defined(DISABLE_SLOW_FILESAPP_TESTS) || defined(OFFICIAL_BUILD)
481 #define MAYBE_TabindexSaveFileDialog DISABLED_TabindexSaveFileDialog 481 #define MAYBE_TabindexSaveFileDialog DISABLED_TabindexSaveFileDialog
482 #else 482 #else
483 #define MAYBE_TabindexSaveFileDialog TabindexSaveFileDialog 483 #define MAYBE_TabindexSaveFileDialog TabindexSaveFileDialog
484 #endif 484 #endif
485 // Flaky: crbug.com/615259
485 WRAPPED_INSTANTIATE_TEST_CASE_P( 486 WRAPPED_INSTANTIATE_TEST_CASE_P(
486 MAYBE_TabindexSaveFileDialog, 487 DISABLED_TabindexSaveFileDialog,
487 FileManagerBrowserTest, 488 FileManagerBrowserTest,
488 ::testing::Values( 489 ::testing::Values(
489 TestParameter(NOT_IN_GUEST_MODE, "tabindexSaveFileDialogDrive"), 490 TestParameter(NOT_IN_GUEST_MODE, "tabindexSaveFileDialogDrive"),
490 TestParameter(NOT_IN_GUEST_MODE, "tabindexSaveFileDialogDownloads"), 491 TestParameter(NOT_IN_GUEST_MODE, "tabindexSaveFileDialogDownloads"),
491 TestParameter(IN_GUEST_MODE, "tabindexSaveFileDialogDownloads"))); 492 TestParameter(IN_GUEST_MODE, "tabindexSaveFileDialogDownloads")));
492 493
493 #if defined(DISABLE_SLOW_FILESAPP_TESTS) || defined(OFFICIAL_BUILD) 494 #if defined(DISABLE_SLOW_FILESAPP_TESTS) || defined(OFFICIAL_BUILD)
494 #define MAYBE_OpenFileDialog DISABLED_OpenFileDialog 495 #define MAYBE_OpenFileDialog DISABLED_OpenFileDialog
495 #else 496 #else
496 #define MAYBE_OpenFileDialog OpenFileDialog 497 #define MAYBE_OpenFileDialog OpenFileDialog
(...skipping 195 matching lines...) Expand 10 before | Expand all | Expand 10 after
692 693
693 IN_PROC_BROWSER_TEST_F(MultiProfileFileManagerBrowserTest, MAYBE_BasicDrive) { 694 IN_PROC_BROWSER_TEST_F(MultiProfileFileManagerBrowserTest, MAYBE_BasicDrive) {
694 AddAllUsers(); 695 AddAllUsers();
695 696
696 // Sanity check that normal operations work in multi-profile setting as well. 697 // Sanity check that normal operations work in multi-profile setting as well.
697 set_test_case_name("keyboardCopyDrive"); 698 set_test_case_name("keyboardCopyDrive");
698 StartTest(); 699 StartTest();
699 } 700 }
700 701
701 } // namespace file_manager 702 } // namespace file_manager
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698