Issue 2022213002: _visitTest should look through parentheses

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2022213002: _visitTest should look through parentheses (Closed)

Created:
4 years, 6 months ago by sra1

Modified:
4 years, 6 months ago

Reviewers:
vsm

CC:
dev-compiler+reviews_dartlang.org

Base URL:
https://github.com/dart-lang/dev_compiler@master

Target Ref:
refs/heads/master

Visibility:
Public.

_visitTest should look through parentheses We were missing using dart.test on expressions like a && (b || c) TBR=vsm@google.com Committed: https://github.com/dart-lang/dev_compiler/commit/ab2a34096ee51def9c4d1f1bd242d95545430933

Created: 4 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+16 lines, -13 lines)			Patch
	M	lib/runtime/dart_sdk.js	View		13 chunks	+13 lines, -13 lines	0 comments	Download
	M	lib/src/compiler/code_generator.dart	View		1 chunk	+3 lines, -0 lines	0 comments	Download

Total messages: 3 (2 generated)

sra1

4 years, 6 months ago (2016-05-31 17:34:42 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
ab2a34096ee51def9c4d1f1bd242d95545430933 (presubmit successful).