lib/src/compiler/code_generator.dart - Issue 2022213002: _visitTest should look through parentheses

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: lib/src/compiler/code_generator.dart

Issue 2022213002: _visitTest should look through parentheses (Closed) Base URL: https://github.com/dart-lang/dev_compiler@master

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: lib/src/compiler/code_generator.dart

diff --git a/lib/src/compiler/code_generator.dart b/lib/src/compiler/code_generator.dart

index dad88eb3fa58f5ca1436eebfa9f3c9fb0b12fff5..6077c26ec543a7704068904a85b2aa28062f9254 100644

--- a/lib/src/compiler/code_generator.dart

+++ b/lib/src/compiler/code_generator.dart

@@ -4390,6 +4390,9 @@ class CodeGenerator extends GeneralizingAstVisitor

if (node is PrefixExpression && node.operator.lexeme == '!') {

return finish(js.call('!#', _visitTest(node.operand)));

}

+ if (node is ParenthesizedExpression) {

+ return finish(_visitTest(node.expression));

+ }

if (node is BinaryExpression) {

JS.Expression shortCircuit(String code) {

return finish(js.call(code,

« no previous file with comments | « lib/runtime/dart_sdk.js ('k') | no next file » | no next file with comments »