Android: Call SetNeedsAnimate() for toolbar animations

Android: Call SetNeedsAnimate() for toolbar animations

Fixes a regression from
https://codereview.chromium.org/1879833002/

The are cases where the frontend drives a toolbar
animation through onVisibleContentOffsetChanged() which
do need to request further commits/draws, so try to disinguish
these.

BUG=608257
Committed: https://crrev.com/5c9ce08f0086cde9519de46351ce1d1fd3cc3684
Cr-Commit-Position: refs/heads/master@{#397252}

[no sievers, 2016-05-31 22:07:21]

Description was changed from

==========
Android: Call SetNeedsAnimate() for toolbar animations

Fixes a regression from
https://codereview.chromium.org/1879833002/

The are cases where the frontend drives a toolbar
animation through onVisibleContentOffsetChanged() which
do need to request further commits/draws, so try to disinguish
these.

BUG=615577
==========

to

==========
Android: Call SetNeedsAnimate() for toolbar animations

Fixes a regression from
https://codereview.chromium.org/1879833002/

The are cases where the frontend drives a toolbar
animation through onVisibleContentOffsetChanged() which
do need to request further commits/draws, so try to disinguish
these.

BUG=608257
==========

[no sievers, 2016-05-31 22:07:21]

sievers@chromium.org changed reviewers:
+ tedchoc@chromium.org

[no sievers, 2016-05-31 22:07:30]

Ted, ptal. Seems to fix the issue.

[Ted C, 2016-05-31 22:25:47]

lgtm...would like a clearer name for the param, but don't really have a great
option either

https://codereview.chromium.org/2022183005/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/fullscreen/ChromeFullscreenManager.java
(right):

https://codereview.chromium.org/2022183005/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/fullscreen/ChromeFullscreenManager.java:108:
* @param needsAnimate Whether the caller is driving an animation with further
updates.
Hmm...this name seems odd to me (or maybe too specific to the compositor).

This class doesn't know if the listeners need to animate as a result of this
call.  It only really knows whether this call was triggered by the browser or
the renderer (most likely).

I guess there isn't a great name for this as the checks below don't actually
account for where their is a browser animation whose offsets are being overruled
by the renderer's as they are in a more visible state.  "maybeFromBrowser"
doesn't exactly have a good ring to it either.  I guess I'll just say it looks
weird and leave it at that.

[no sievers, 2016-05-31 22:28:45]

On 2016/05/31 22:25:47, Ted C wrote:
> lgtm...would like a clearer name for the param, but don't really have a great
> option either
> 
>
https://codereview.chromium.org/2022183005/diff/1/chrome/android/java/src/org...
> File
>
chrome/android/java/src/org/chromium/chrome/browser/fullscreen/ChromeFullscreenManager.java
> (right):
> 
>
https://codereview.chromium.org/2022183005/diff/1/chrome/android/java/src/org...
>
chrome/android/java/src/org/chromium/chrome/browser/fullscreen/ChromeFullscreenManager.java:108:
> * @param needsAnimate Whether the caller is driving an animation with further
> updates.
> Hmm...this name seems odd to me (or maybe too specific to the compositor).
> 
> This class doesn't know if the listeners need to animate as a result of this
> call.  It only really knows whether this call was triggered by the browser or
> the renderer (most likely).
> 
> I guess there isn't a great name for this as the checks below don't actually
> account for where their is a browser animation whose offsets are being
overruled
> by the renderer's as they are in a more visible state.  "maybeFromBrowser"
> doesn't exactly have a good ring to it either.  I guess I'll just say it looks
> weird and leave it at that.

Yea it's not great. But maybe with the comment it's ok?
'needs animate' kinda fits the notion we're doing an animation according to the
|mControlAnimation != null| it's doing.

[no sievers, 2016-06-01 21:23:05]

The CQ bit was checked by sievers@chromium.org

[commit-bot: I haz the power, 2016-06-01 21:23:47]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2022183005/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2022183005/1

[commit-bot: I haz the power, 2016-06-01 21:29:44]

Description was changed from

==========
Android: Call SetNeedsAnimate() for toolbar animations

Fixes a regression from
https://codereview.chromium.org/1879833002/

The are cases where the frontend drives a toolbar
animation through onVisibleContentOffsetChanged() which
do need to request further commits/draws, so try to disinguish
these.

BUG=608257
==========

to

==========
Android: Call SetNeedsAnimate() for toolbar animations

Fixes a regression from
https://codereview.chromium.org/1879833002/

The are cases where the frontend drives a toolbar
animation through onVisibleContentOffsetChanged() which
do need to request further commits/draws, so try to disinguish
these.

BUG=608257
==========

[commit-bot: I haz the power, 2016-06-01 21:29:45]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-06-01 21:32:29]

Description was changed from

==========
Android: Call SetNeedsAnimate() for toolbar animations

Fixes a regression from
https://codereview.chromium.org/1879833002/

The are cases where the frontend drives a toolbar
animation through onVisibleContentOffsetChanged() which
do need to request further commits/draws, so try to disinguish
these.

BUG=608257
==========

to

==========
Android: Call SetNeedsAnimate() for toolbar animations

Fixes a regression from
https://codereview.chromium.org/1879833002/

The are cases where the frontend drives a toolbar
animation through onVisibleContentOffsetChanged() which
do need to request further commits/draws, so try to disinguish
these.

BUG=608257

Committed: https://crrev.com/5c9ce08f0086cde9519de46351ce1d1fd3cc3684
Cr-Commit-Position: refs/heads/master@{#397252}
==========

[commit-bot: I haz the power, 2016-06-01 21:32:30]

Patchset 1 (id:??) landed as
https://crrev.com/5c9ce08f0086cde9519de46351ce1d1fd3cc3684
Cr-Commit-Position: refs/heads/master@{#397252}