chrome/android/java/src/org/chromium/chrome/browser/compositor/CompositorViewHolder.java - Issue 2022183005: Android: Call SetNeedsAnimate() for toolbar animations

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/compositor/CompositorViewHolder.java

Issue 2022183005: Android: Call SetNeedsAnimate() for toolbar animations (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | chrome/android/java/src/org/chromium/chrome/browser/fullscreen/ChromeFullscreenManager.java » ('j') | chrome/android/java/src/org/chromium/chrome/browser/fullscreen/ChromeFullscreenManager.java » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/compositor/CompositorViewHolder.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/compositor/CompositorViewHolder.java b/chrome/android/java/src/org/chromium/chrome/browser/compositor/CompositorViewHolder.java

index 6e220d4bbb7dde32438db038d93cc204cddb7c04..bc3d550b1ad89e0a56672acb2e093745a22c8989 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/compositor/CompositorViewHolder.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/compositor/CompositorViewHolder.java

@@ -455,9 +455,10 @@ public class CompositorViewHolder extends CoordinatorLayout

}

@Override

- public void onVisibleContentOffsetChanged(float offset) {

+ public void onVisibleContentOffsetChanged(float offset, boolean needsAnimate) {

mLastVisibleContentOffset = offset;

propagateViewportToLayouts(getWidth(), getHeight());

+ if (needsAnimate) requestRender();

}

@Override