components/autofill/content/renderer/form_autofill_util.cc - Issue 2022123002: Merge autofill::FormFieldData::is_checkable and is_checked

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/autofill/content/renderer/form_autofill_util.cc

Issue 2022123002: Merge autofill::FormFieldData::is_checkable and is_checked (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/autofill/content/common/autofill_messages.h ('k') | components/autofill/core/browser/autofill_metrics_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/autofill/content/renderer/form_autofill_util.cc

diff --git a/components/autofill/content/renderer/form_autofill_util.cc b/components/autofill/content/renderer/form_autofill_util.cc

index cf0e30fe11cb45ab94de0a502049eb69290d9544..c2e6030da9ade379b15af4af3c67fa7e32bffe4c 100644

--- a/components/autofill/content/renderer/form_autofill_util.cc

+++ b/components/autofill/content/renderer/form_autofill_util.cc

@@ -889,7 +889,7 @@ void FillFormField(const FormFieldData& data,

WebInputElement* input_element = toWebInputElement(field);

if (IsCheckableElement(input_element)) {

- input_element->setChecked(data.is_checked, true);

+ input_element->setChecked(IsChecked(data.check_status), true);

} else {

base::string16 value = data.value;

if (IsTextInput(input_element) || IsMonthInput(input_element)) {

@@ -1404,8 +1404,8 @@ void WebFormControlElementToFormField(const WebFormControlElement& element,

if (IsTextInput(input_element))

field->max_length = input_element->maxLength();

- field->is_checkable = IsCheckableElement(input_element);

- field->is_checked = input_element->isChecked();

+ SetCheckStatus(field, IsCheckableElement(input_element),

+ input_element->isChecked());

} else if (IsTextAreaElement(element)) {

// Nothing more to do in this case.

} else if (extract_mask & EXTRACT_OPTIONS) {