components/autofill/content/common/autofill_messages.h - Issue 2022123002: Merge autofill::FormFieldData::is_checkable and is_checked

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/autofill/content/common/autofill_messages.h

Issue 2022123002: Merge autofill::FormFieldData::is_checkable and is_checked (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/renderer/autofill/form_autofill_browsertest.cc ('k') | components/autofill/content/renderer/form_autofill_util.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/autofill/content/common/autofill_messages.h

diff --git a/components/autofill/content/common/autofill_messages.h b/components/autofill/content/common/autofill_messages.h

index 649e05281a285c22b4c90203967f37136c55ea47..617c7a3d0e4758904be87f006cc6fcfdf2af2c97 100644

--- a/components/autofill/content/common/autofill_messages.h

+++ b/components/autofill/content/common/autofill_messages.h

@@ -29,6 +29,9 @@

#define IPC_MESSAGE_START AutofillMsgStart

+IPC_ENUM_TRAITS_MAX_VALUE(autofill::FormFieldData::CheckStatus,

+ autofill::FormFieldData::CheckStatus::CHECKED)

IPC_ENUM_TRAITS_MAX_VALUE(autofill::FormFieldData::RoleAttribute,

autofill::FormFieldData::ROLE_ATTRIBUTE_OTHER)

@@ -49,8 +52,7 @@ IPC_STRUCT_TRAITS_BEGIN(autofill::FormFieldData)

IPC_STRUCT_TRAITS_MEMBER(role)

IPC_STRUCT_TRAITS_MEMBER(max_length)

IPC_STRUCT_TRAITS_MEMBER(is_autofilled)

- IPC_STRUCT_TRAITS_MEMBER(is_checked)

- IPC_STRUCT_TRAITS_MEMBER(is_checkable)

+ IPC_STRUCT_TRAITS_MEMBER(check_status)

IPC_STRUCT_TRAITS_MEMBER(is_focusable)

IPC_STRUCT_TRAITS_MEMBER(should_autocomplete)

IPC_STRUCT_TRAITS_MEMBER(text_direction)