Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(72)

Issue 2022103002: Move GLSurfaceOSMesaX11 into it's own source file. (Closed)

Created:
4 years, 6 months ago by kylechar
Modified:
4 years, 6 months ago
Reviewers:
piman
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move GLSurfaceOSMesaX11 into it's own source file. The initialization code in GLSurfaceOSMesaX11 needs to be used from //ui/gl/init and as such can't be in anonymous namespace. Expose the class similar to other GLSurface implementations. BUG=611142 Committed: https://crrev.com/c192fbb4329e5c5cf106d208ff359f5f085c34f2 Cr-Commit-Position: refs/heads/master@{#396911}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+242 lines, -224 lines) Patch
M ui/gl/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
M ui/gl/gl.gyp View 1 chunk +2 lines, -0 lines 0 comments Download
A ui/gl/gl_surface_osmesa_x11.h View 1 chunk +52 lines, -0 lines 0 comments Download
A ui/gl/gl_surface_osmesa_x11.cc View 1 chunk +182 lines, -0 lines 0 comments Download
M ui/gl/gl_surface_x11.cc View 3 chunks +4 lines, -224 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 12 (5 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2022103002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2022103002/1
4 years, 6 months ago (2016-05-31 14:39:12 UTC) #2
kylechar
4 years, 6 months ago (2016-05-31 16:13:28 UTC) #4
piman
lgtm
4 years, 6 months ago (2016-05-31 16:48:46 UTC) #5
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_android_rel_ng on tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/79065)
4 years, 6 months ago (2016-05-31 17:19:02 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2022103002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2022103002/1
4 years, 6 months ago (2016-05-31 19:04:23 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-05-31 20:12:08 UTC) #10
commit-bot: I haz the power
4 years, 6 months ago (2016-05-31 20:45:06 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c192fbb4329e5c5cf106d208ff359f5f085c34f2
Cr-Commit-Position: refs/heads/master@{#396911}

Powered by Google App Engine
This is Rietveld 408576698