Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(252)

Unified Diff: Source/bindings/v8/custom/V8OscillatorNodeCustom.cpp

Issue 202203009: Rename |imp| => |impl| in bindings generation (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: custom/v8 too Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/bindings/v8/custom/V8NodeCustom.cpp ('k') | Source/bindings/v8/custom/V8PannerNodeCustom.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/bindings/v8/custom/V8OscillatorNodeCustom.cpp
diff --git a/Source/bindings/v8/custom/V8OscillatorNodeCustom.cpp b/Source/bindings/v8/custom/V8OscillatorNodeCustom.cpp
index f6db41308d4f4d65a6563f5fba4ee5d69b0354e7..ca00520ff343c84e91d07b2cd38935214ad34177 100644
--- a/Source/bindings/v8/custom/V8OscillatorNodeCustom.cpp
+++ b/Source/bindings/v8/custom/V8OscillatorNodeCustom.cpp
@@ -36,13 +36,13 @@ void V8OscillatorNode::typeAttributeSetterCustom(v8::Local<v8::Value> value, con
{
ExceptionState exceptionState(ExceptionState::SetterContext, "type", "OscillatorNode", info.Holder(), info.GetIsolate());
v8::Handle<v8::Object> holder = info.Holder();
- OscillatorNode* imp = V8OscillatorNode::toNative(holder);
+ OscillatorNode* impl = V8OscillatorNode::toNative(holder);
if (value->IsNumber()) {
uint32_t type = toUInt32(value, exceptionState);
if (exceptionState.throwIfNeeded())
return;
- if (!imp->setType(type)) {
+ if (!impl->setType(type)) {
exceptionState.throwTypeError("Illegal OscillatorNode type");
exceptionState.throwIfNeeded();
}
@@ -52,7 +52,7 @@ void V8OscillatorNode::typeAttributeSetterCustom(v8::Local<v8::Value> value, con
if (value->IsString()) {
String type = toCoreString(value.As<v8::String>());
if (type == "sine" || type == "square" || type == "sawtooth" || type == "triangle") {
- imp->setType(type);
+ impl->setType(type);
return;
}
}
« no previous file with comments | « Source/bindings/v8/custom/V8NodeCustom.cpp ('k') | Source/bindings/v8/custom/V8PannerNodeCustom.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698