Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(191)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2021913002: ✨ Minor cleanup of launching document tabs. (Closed)

Created:
4 years, 6 months ago by Peter Wen
Modified:
4 years, 6 months ago
Reviewers:
gone
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Minor cleanup of launching document tabs. BUG=612245, 509886 Committed: https://crrev.com/a918d71efc4e42d341f0a102a35743c1439fa125 Cr-Commit-Position: refs/heads/master@{#396912}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fix nit. #

Messages

Total messages: 10 (4 generated)
Peter Wen
Tested that M50 migration still works. ✔
4 years, 6 months ago (2016-05-30 16:28:38 UTC) #2
gone
lgtm https://codereview.chromium.org/2021913002/diff/1/chrome/android/java/src/org/chromium/chrome/browser/ChromeServiceTabLauncher.java File chrome/android/java/src/org/chromium/chrome/browser/ChromeServiceTabLauncher.java (right): https://codereview.chromium.org/2021913002/diff/1/chrome/android/java/src/org/chromium/chrome/browser/ChromeServiceTabLauncher.java#newcode60 chrome/android/java/src/org/chromium/chrome/browser/ChromeServiceTabLauncher.java:60: nit: remove this newline
4 years, 6 months ago (2016-05-31 17:59:53 UTC) #3
Peter Wen
Thanks for the review! https://codereview.chromium.org/2021913002/diff/1/chrome/android/java/src/org/chromium/chrome/browser/ChromeServiceTabLauncher.java File chrome/android/java/src/org/chromium/chrome/browser/ChromeServiceTabLauncher.java (right): https://codereview.chromium.org/2021913002/diff/1/chrome/android/java/src/org/chromium/chrome/browser/ChromeServiceTabLauncher.java#newcode60 chrome/android/java/src/org/chromium/chrome/browser/ChromeServiceTabLauncher.java:60: On 2016/05/31 17:59:53, dfalcantara wrote: ...
4 years, 6 months ago (2016-05-31 18:28:15 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2021913002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2021913002/20001
4 years, 6 months ago (2016-05-31 18:28:53 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 6 months ago (2016-05-31 20:18:34 UTC) #8
commit-bot: I haz the power
4 years, 6 months ago (2016-05-31 20:45:11 UTC) #10
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/a918d71efc4e42d341f0a102a35743c1439fa125
Cr-Commit-Position: refs/heads/master@{#396912}

Powered by Google App Engine
This is Rietveld 408576698