Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3631)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/tabmodel/document/AsyncTabCreationParams.java

Issue 2021913002: ✨ Minor cleanup of launching document tabs. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix nit. Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/tabmodel/document/AsyncTabCreationParams.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/tabmodel/document/AsyncTabCreationParams.java b/chrome/android/java/src/org/chromium/chrome/browser/tabmodel/document/AsyncTabCreationParams.java
index 3d6ad22cf168fb7ca83a5455f3f07e384b93a68d..33066d3d141fb8d171823c39acda595faa29ded5 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/tabmodel/document/AsyncTabCreationParams.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/tabmodel/document/AsyncTabCreationParams.java
@@ -6,8 +6,8 @@ package org.chromium.chrome.browser.tabmodel.document;
import android.content.Intent;
+import org.chromium.chrome.browser.ChromeServiceTabLauncher;
import org.chromium.chrome.browser.document.ChromeLauncherActivity;
-import org.chromium.chrome.browser.document.DocumentMetricIds;
import org.chromium.chrome.browser.tab.Tab;
import org.chromium.chrome.browser.tabmodel.AsyncTabParams;
import org.chromium.content_public.browser.LoadUrlParams;
@@ -30,15 +30,6 @@ public class AsyncTabCreationParams implements AsyncTabParams {
/** The tab launch request ID from the {@link ChromeServiceTabLauncher}. **/
private final Integer mRequestId;
- /** How to start a {@link DocumentTab}. */
- private int mDocumentLaunchMode = ChromeLauncherActivity.LAUNCH_MODE_FOREGROUND;
-
- /** What caused a {@link DocumentTab} to be created. */
- private int mDocumentStartedBy = DocumentMetricIds.STARTED_BY_UNKNOWN;
-
- /** Whether or not the {@link WebContents} should be initially hidden. */
- private boolean mIsAffiliated;
-
/** Create parameters for creating a Tab asynchronously. */
public AsyncTabCreationParams(LoadUrlParams loadUrlParams) {
this(loadUrlParams, null, null, null);
@@ -62,22 +53,6 @@ public class AsyncTabCreationParams implements AsyncTabParams {
assert requestId != null;
}
- public void setDocumentLaunchMode(int launchMode) {
- mDocumentLaunchMode = launchMode;
- }
-
- public void setDocumentStartedBy(int startedBy) {
- mDocumentStartedBy = startedBy;
- }
-
- public int getDocumentLaunchMode() {
- return mDocumentLaunchMode;
- }
-
- public int getDocumentStartedBy() {
- return mDocumentStartedBy;
- }
-
@Override
public LoadUrlParams getLoadUrlParams() {
return mLoadUrlParams;
@@ -98,14 +73,6 @@ public class AsyncTabCreationParams implements AsyncTabParams {
return mWebContents;
}
- public void setIsAffiliated(boolean isAffiliated) {
- mIsAffiliated = isAffiliated;
- }
-
- public boolean isAffiliated() {
- return mIsAffiliated;
- }
-
private AsyncTabCreationParams(LoadUrlParams loadUrlParams, Intent originalIntent,
WebContents webContents, Integer requestId) {
assert loadUrlParams != null;

Powered by Google App Engine
This is Rietveld 408576698