src/heap/spaces.h - Issue 2021823002: [heap] Fix recording on aborted code pages

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/heap/spaces.h

Issue 2021823002: [heap] Fix recording on aborted code pages (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/heap/spaces.h

diff --git a/src/heap/spaces.h b/src/heap/spaces.h

index 59d8cfb6d9ed6d9d7c06d8e9d58689cb2950437e..5d05d297629d88520696eaab0c26819aec441332 100644

--- a/src/heap/spaces.h

+++ b/src/heap/spaces.h

@@ -713,7 +713,8 @@ class MemoryChunk {

}

bool ShouldSkipEvacuationSlotRecording() {

- return (flags_ & kSkipEvacuationSlotsRecordingMask) != 0;

+ return ((flags_ & kSkipEvacuationSlotsRecordingMask) != 0) &&

+ !IsFlagSet(COMPACTION_WAS_ABORTED);

}

Executability executable() {

« no previous file with comments | « src/heap/mark-compact.cc ('k') | no next file » | no next file with comments »