Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(74)

Side by Side Diff: src/heap/spaces.h

Issue 2021823002: [heap] Fix recording on aborted code pages (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/heap/mark-compact.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2011 the V8 project authors. All rights reserved. 1 // Copyright 2011 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef V8_HEAP_SPACES_H_ 5 #ifndef V8_HEAP_SPACES_H_
6 #define V8_HEAP_SPACES_H_ 6 #define V8_HEAP_SPACES_H_
7 7
8 #include <list> 8 #include <list>
9 9
10 #include "src/allocation.h" 10 #include "src/allocation.h"
(...skipping 695 matching lines...) Expand 10 before | Expand all | Expand 10 after
706 bool IsEvacuationCandidate() { 706 bool IsEvacuationCandidate() {
707 DCHECK(!(IsFlagSet(NEVER_EVACUATE) && IsFlagSet(EVACUATION_CANDIDATE))); 707 DCHECK(!(IsFlagSet(NEVER_EVACUATE) && IsFlagSet(EVACUATION_CANDIDATE)));
708 return IsFlagSet(EVACUATION_CANDIDATE); 708 return IsFlagSet(EVACUATION_CANDIDATE);
709 } 709 }
710 710
711 bool CanAllocate() { 711 bool CanAllocate() {
712 return !IsEvacuationCandidate() && !IsFlagSet(NEVER_ALLOCATE_ON_PAGE); 712 return !IsEvacuationCandidate() && !IsFlagSet(NEVER_ALLOCATE_ON_PAGE);
713 } 713 }
714 714
715 bool ShouldSkipEvacuationSlotRecording() { 715 bool ShouldSkipEvacuationSlotRecording() {
716 return (flags_ & kSkipEvacuationSlotsRecordingMask) != 0; 716 return ((flags_ & kSkipEvacuationSlotsRecordingMask) != 0) &&
717 !IsFlagSet(COMPACTION_WAS_ABORTED);
717 } 718 }
718 719
719 Executability executable() { 720 Executability executable() {
720 return IsFlagSet(IS_EXECUTABLE) ? EXECUTABLE : NOT_EXECUTABLE; 721 return IsFlagSet(IS_EXECUTABLE) ? EXECUTABLE : NOT_EXECUTABLE;
721 } 722 }
722 723
723 bool InNewSpace() { 724 bool InNewSpace() {
724 return (flags_ & ((1 << IN_FROM_SPACE) | (1 << IN_TO_SPACE))) != 0; 725 return (flags_ & ((1 << IN_FROM_SPACE) | (1 << IN_TO_SPACE))) != 0;
725 } 726 }
726 727
(...skipping 2429 matching lines...) Expand 10 before | Expand all | Expand 10 after
3156 count = 0; 3157 count = 0;
3157 } 3158 }
3158 // Must be small, since an iteration is used for lookup. 3159 // Must be small, since an iteration is used for lookup.
3159 static const int kMaxComments = 64; 3160 static const int kMaxComments = 64;
3160 }; 3161 };
3161 #endif 3162 #endif
3162 } // namespace internal 3163 } // namespace internal
3163 } // namespace v8 3164 } // namespace v8
3164 3165
3165 #endif // V8_HEAP_SPACES_H_ 3166 #endif // V8_HEAP_SPACES_H_
OLDNEW
« no previous file with comments | « src/heap/mark-compact.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698