Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(132)

Issue 2021783003: Make WebRTC patches apply to Chromium checkouts on Windows. (Closed)

Created:
4 years, 6 months ago by kjellander_chromium
Modified:
4 years, 6 months ago
Reviewers:
Paweł Hajdan Jr.
CC:
chromium-reviews, dpranke+depot_tools_chromium.org, iannucci+depot_tools_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/depot_tools.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Make WebRTC patches apply to Chromium checkouts on Windows. The change in https://codereview.chromium.org/1982243002 didn't take into account that the script runs on the actual bot OS, so Windows will have backslashes as dir separators. BUG=438952 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=300672

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M recipe_modules/bot_update/resources/bot_update.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (4 generated)
kjellander_chromium
4 years, 6 months ago (2016-05-30 14:58:11 UTC) #2
Paweł Hajdan Jr.
LGTM
4 years, 6 months ago (2016-05-30 15:00:07 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2021783003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2021783003/1
4 years, 6 months ago (2016-05-30 15:00:31 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1) as http://src.chromium.org/viewvc/chrome?view=rev&revision=300672
4 years, 6 months ago (2016-05-30 15:03:58 UTC) #8
kjellander_chromium
4 years, 6 months ago (2016-05-30 15:35:16 UTC) #9
Message was sent while issue was closed.
On 2016/05/30 15:03:58, commit-bot: I haz the power wrote:
> Committed patchset #1 (id:1) as
> http://src.chromium.org/viewvc/chrome?view=rev&revision=300672

I can confirm bot_update now applies the patch correctly, see tryruns at
https://codereview.webrtc.org/1979933002/#ps40001

Powered by Google App Engine
This is Rietveld 408576698