Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(304)

Issue 1982243002: Use --extra_patchlevel for WebRTC patches on Chromium trybots. (Closed)

Created:
4 years, 7 months ago by kjellander_chromium
Modified:
4 years, 7 months ago
Reviewers:
tandrii(chromium)
CC:
chromium-reviews, dpranke+depot_tools_chromium.org, iannucci+depot_tools_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/depot_tools.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Use --extra_patchlevel for WebRTC patches on Chromium trybots. The --extra_patchlevel flag was added in https://codereview.chromium.org/1988583002/ In order to make it possible for WebRTC patches to apply in src/third_party/webrtc of a Chromium checkout, one directory level needs to be trimmed. BUG=438952, 611808 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=300618

Patch Set 1 #

Patch Set 2 : Correct path #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M recipe_modules/bot_update/resources/bot_update.py View 1 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
kjellander_chromium
4 years, 7 months ago (2016-05-17 07:20:51 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1982243002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1982243002/1
4 years, 7 months ago (2016-05-17 07:21:35 UTC) #5
tandrii(chromium)
LGTM
4 years, 7 months ago (2016-05-17 07:23:48 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1982243002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1982243002/40001
4 years, 7 months ago (2016-05-17 07:24:27 UTC) #10
commit-bot: I haz the power
4 years, 7 months ago (2016-05-17 07:27:20 UTC) #12
Message was sent while issue was closed.
Committed patchset #2 (id:40001) as
http://src.chromium.org/viewvc/chrome?view=rev&revision=300618

Powered by Google App Engine
This is Rietveld 408576698