Add a queue for custom element reactions.

Add a queue for custom element reactions.

https://html.spec.whatwg.org/multipage/scripting.html#custom-element-reaction-queue

BUG=594918
R=kojii@chromium.org

Committed: https://chromium.googlesource.com/chromium/src/+/df3420344c2d85b0510edf895fa8e8cf7531adce

[dominicc (has gone to gerrit), 2016-05-30 07:55:46]

dominicc@chromium.org changed reviewers:
+ kojii@chromium.org

[dominicc (has gone to gerrit), 2016-05-30 07:57:24]

PTAL

I think I will split up my upgrade patch into the core/dom parts and the
bindings/ parts to make the reviews more focused. It might mean we have to churn
the core/dom side if bindings/ requires changes but it will probably be faster.

This is the reaction queue. Element queue coming next.

[kojii, 2016-05-30 11:30:23]

lgtm

[dominicc (has gone to gerrit), 2016-05-30 21:42:26]

The CQ bit was checked by dominicc@chromium.org

[commit-bot: I haz the power, 2016-05-30 21:42:32]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2021763002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2021763002/1

[commit-bot: I haz the power, 2016-05-30 23:32:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-30 23:33:00]

Try jobs failed on following builders:
  linux_android_rel_ng on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[dominicc (has gone to gerrit), 2016-05-31 01:47:09]

The CQ bit was checked by dominicc@chromium.org

[commit-bot: I haz the power, 2016-05-31 01:47:16]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2021763002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2021763002/1

[commit-bot: I haz the power, 2016-05-31 03:34:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-31 03:34:57]

Try jobs failed on following builders:
  linux_android_rel_ng on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[dominicc (has gone to gerrit), 2016-05-31 04:18:05]

The CQ bit was checked by dominicc@chromium.org

[commit-bot: I haz the power, 2016-05-31 04:18:18]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2021763002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2021763002/1

[commit-bot: I haz the power, 2016-05-31 05:55:50]

Description was changed from

==========
Add a queue for custom element reactions.

https://html.spec.whatwg.org/multipage/scripting.html#custom-element-reaction...

BUG=594918
==========

to

==========
Add a queue for custom element reactions.

https://html.spec.whatwg.org/multipage/scripting.html#custom-element-reaction...

BUG=594918
R=kojii@chromium.org

Committed: https://crrev.com/df3420344c2d85b0510edf895fa8e8cf7531adce
Cr-Commit-Position: refs/heads/master@{#396790}
==========

[commit-bot: I haz the power, 2016-05-31 05:55:51]

Patchset 1 (id:??) landed as
https://crrev.com/df3420344c2d85b0510edf895fa8e8cf7531adce
Cr-Commit-Position: refs/heads/master@{#396790}

[dominicc (has gone to gerrit), 2016-05-31 05:56:49]

Description was changed from

==========
Add a queue for custom element reactions.

https://html.spec.whatwg.org/multipage/scripting.html#custom-element-reaction...

BUG=594918
R=kojii@chromium.org

Committed: https://crrev.com/df3420344c2d85b0510edf895fa8e8cf7531adce
Cr-Commit-Position: refs/heads/master@{#396790}
==========

to

==========
Add a queue for custom element reactions.

https://html.spec.whatwg.org/multipage/scripting.html#custom-element-reaction...

BUG=594918
R=kojii@chromium.org

Committed:
https://chromium.googlesource.com/chromium/src/+/df3420344c2d85b0510edf895fa8...
==========

[dominicc (has gone to gerrit), 2016-05-31 05:56:52]

Committed patchset #1 (id:1) manually as
df3420344c2d85b0510edf895fa8e8cf7531adce (presubmit successful).

[yosin_UTC9, 2016-06-01 02:14:00]

yosin@chromium.org changed reviewers:
+ yosin@chromium.org

[yosin_UTC9, 2016-06-01 02:14:01]

https://codereview.chromium.org/2021763002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/dom/custom/CustomElementReaction.h (right):

https://codereview.chromium.org/2021763002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/dom/custom/CustomElementReaction.h:20:
CustomElementReaction() { }
nit: %s/{ }/ = default/

https://codereview.chromium.org/2021763002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/dom/custom/CustomElementReactionQueue.cpp
(right):

https://codereview.chromium.org/2021763002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/dom/custom/CustomElementReactionQueue.cpp:11:
CustomElementReactionQueue::CustomElementReactionQueue()
Better to use |m_index = 0u| in class declaration and use |= default|

https://codereview.chromium.org/2021763002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/dom/custom/CustomElementReactionQueue.cpp:16:
CustomElementReactionQueue::~CustomElementReactionQueue()
nit: = default

https://codereview.chromium.org/2021763002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/dom/custom/CustomElementReactionQueue.h
(right):

https://codereview.chromium.org/2021763002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/dom/custom/CustomElementReactionQueue.h:19:
WTF_MAKE_NONCOPYABLE(CustomElementReactionQueue);
Better to use DISALLOW_COPY_AND_ASSIGN()?

https://codereview.chromium.org/2021763002/diff/1/third_party/WebKit/Source/c...
File
third_party/WebKit/Source/core/dom/custom/CustomElementReactionQueueTest.cpp
(right):

https://codereview.chromium.org/2021763002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/dom/custom/CustomElementReactionQueueTest.cpp:142:
EXPECT_EQ(log, std::vector<char>({'a', 'b', 'c'}))
Wow, gtest's *_EQ(expect, actual) is now historical convention!

Excerpt from:
https://github.com/google/googletest/blob/master/googletest/docs/Primer.md

Historical note: Before February 2016 *_EQ had a convention of calling it as
ASSERT_EQ(expected, actual), so lots of existing code uses this order. Now *_EQ
treats both parameters in the same way.