Issue 202173005: Fix "unreachable code" warnings (MSVC warning 4702) in ui/.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 202173005: Fix "unreachable code" warnings (MSVC warning 4702) in ui/. (Closed)

Created:
6 years, 9 months ago by Peter Kasting

Modified:
6 years, 9 months ago

Reviewers:
sky

CC:
chromium-reviews, tfarina, ben+views_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Fix "unreachable code" warnings (MSVC warning 4702) in ui/. BUG=346399 TEST=none R=sky@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=257745

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+16 lines, -13 lines)			Patch
M	ui/gfx/animation/animation.cc	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	ui/gl/gl_implementation_win.cc	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	ui/shell_dialogs/select_file_dialog.cc	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	ui/views/event_utils_aura.cc	View	2 chunks	+7 lines, -8 lines	0 comments	Download
M	ui/views/widget/widget.cc	View	3 chunks	+5 lines, -1 line	0 comments	Download

Total messages: 3 (0 generated)

Peter Kasting

6 years, 9 months ago (2014-03-18 20:51:11 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r257745 (presubmit successful).