Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(751)

Side by Side Diff: ui/shell_dialogs/select_file_dialog.cc

Issue 202173005: Fix "unreachable code" warnings (MSVC warning 4702) in ui/. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « ui/gl/gl_implementation_win.cc ('k') | ui/views/event_utils_aura.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "ui/shell_dialogs/select_file_dialog.h" 5 #include "ui/shell_dialogs/select_file_dialog.h"
6 6
7 #include "base/bind.h" 7 #include "base/bind.h"
8 #include "base/logging.h" 8 #include "base/logging.h"
9 #include "base/message_loop/message_loop.h" 9 #include "base/message_loop/message_loop.h"
10 #include "build/build_config.h" 10 #include "build/build_config.h"
(...skipping 76 matching lines...) Expand 10 before | Expand all | Expand 10 after
87 #if defined(OS_WIN) 87 #if defined(OS_WIN)
88 // TODO(ananta) 88 // TODO(ananta)
89 // Fix this for Chrome ASH on Windows. 89 // Fix this for Chrome ASH on Windows.
90 return CreateWinSelectFileDialog(listener, policy); 90 return CreateWinSelectFileDialog(listener, policy);
91 #elif defined(OS_MACOSX) && !defined(USE_AURA) 91 #elif defined(OS_MACOSX) && !defined(USE_AURA)
92 return CreateMacSelectFileDialog(listener, policy); 92 return CreateMacSelectFileDialog(listener, policy);
93 #elif defined(TOOLKIT_GTK) 93 #elif defined(TOOLKIT_GTK)
94 return CreateLinuxSelectFileDialog(listener, policy); 94 return CreateLinuxSelectFileDialog(listener, policy);
95 #elif defined(OS_ANDROID) 95 #elif defined(OS_ANDROID)
96 return CreateAndroidSelectFileDialog(listener, policy); 96 return CreateAndroidSelectFileDialog(listener, policy);
97 #else
98 return NULL;
97 #endif 99 #endif
98
99 return NULL;
100 } 100 }
101 101
102 void SelectFileDialog::SelectFile( 102 void SelectFileDialog::SelectFile(
103 Type type, 103 Type type,
104 const base::string16& title, 104 const base::string16& title,
105 const base::FilePath& default_path, 105 const base::FilePath& default_path,
106 const FileTypeInfo* file_types, 106 const FileTypeInfo* file_types,
107 int file_type_index, 107 int file_type_index,
108 const base::FilePath::StringType& default_extension, 108 const base::FilePath::StringType& default_extension,
109 gfx::NativeWindow owning_window, 109 gfx::NativeWindow owning_window,
(...skipping 39 matching lines...) Expand 10 before | Expand all | Expand 10 after
149 void SelectFileDialog::CancelFileSelection(void* params) { 149 void SelectFileDialog::CancelFileSelection(void* params) {
150 if (listener_) 150 if (listener_)
151 listener_->FileSelectionCanceled(params); 151 listener_->FileSelectionCanceled(params);
152 } 152 }
153 153
154 ShellDialogsDelegate* SelectFileDialog::GetShellDialogsDelegate() { 154 ShellDialogsDelegate* SelectFileDialog::GetShellDialogsDelegate() {
155 return g_shell_dialogs_delegate_; 155 return g_shell_dialogs_delegate_;
156 } 156 }
157 157
158 } // namespace ui 158 } // namespace ui
OLDNEW
« no previous file with comments | « ui/gl/gl_implementation_win.cc ('k') | ui/views/event_utils_aura.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698