Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(637)

Issue 2021693002: Convert controls-* tests to testharness.js (Closed)

Created:
4 years, 6 months ago by Srirama
Modified:
4 years, 6 months ago
Reviewers:
fs, foolip
CC:
blink-reviews, chromium-reviews, eric.carlson_apple.com, feature-media-reviews_chromium.org, mlamouri+watch-blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Convert controls-* tests to testharness.js Cleaning up controls-* tests in media/ to use testharness.js instead of video-test.js. This will enable to upstream these tests to web-platform-tests. BUG=588956 Committed: https://crrev.com/d06818a0702f013dd29b468a669c812755435273 Cr-Commit-Position: refs/heads/master@{#396703}

Patch Set 1 #

Total comments: 4

Patch Set 2 : address nits #

Messages

Total messages: 12 (6 generated)
Srirama
PTAL
4 years, 6 months ago (2016-05-29 04:49:44 UTC) #3
fs
lgtm https://codereview.chromium.org/2021693002/diff/1/third_party/WebKit/LayoutTests/media/controls-timeline.html File third_party/WebKit/LayoutTests/media/controls-timeline.html (right): https://codereview.chromium.org/2021693002/diff/1/third_party/WebKit/LayoutTests/media/controls-timeline.html#newcode23 third_party/WebKit/LayoutTests/media/controls-timeline.html:23: var time = video.currentTime / video.duration; Nit: Maybe ...
4 years, 6 months ago (2016-05-29 14:52:43 UTC) #4
Srirama
https://codereview.chromium.org/2021693002/diff/1/third_party/WebKit/LayoutTests/media/controls-timeline.html File third_party/WebKit/LayoutTests/media/controls-timeline.html (right): https://codereview.chromium.org/2021693002/diff/1/third_party/WebKit/LayoutTests/media/controls-timeline.html#newcode23 third_party/WebKit/LayoutTests/media/controls-timeline.html:23: var time = video.currentTime / video.duration; On 2016/05/29 14:52:43, ...
4 years, 6 months ago (2016-05-30 07:55:14 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2021693002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2021693002/20001
4 years, 6 months ago (2016-05-30 07:55:35 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 6 months ago (2016-05-30 09:39:34 UTC) #10
commit-bot: I haz the power
4 years, 6 months ago (2016-05-30 09:41:17 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/d06818a0702f013dd29b468a669c812755435273
Cr-Commit-Position: refs/heads/master@{#396703}

Powered by Google App Engine
This is Rietveld 408576698