third_party/WebKit/LayoutTests/media/controls-volume-slider-keynav.html - Issue 2021693002: Convert controls-* tests to testharness.js

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/media/controls-volume-slider-keynav.html

Issue 2021693002: Convert controls-* tests to testharness.js (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« third_party/WebKit/LayoutTests/media/controls-timeline.html ('K') | « third_party/WebKit/LayoutTests/media/controls-volume-slider-expected.txt ('k') | third_party/WebKit/LayoutTests/media/controls-volume-slider-keynav-expected.txt » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <!doctype html>	1 <!DOCTYPE html>

2 <html>	2 <title>Test media controls volume slider keyboard navigation</title>

3 <head>	3 <script src="../resources/testharness.js"></script>

4 <title>media controls volume slider keyboard navigation</title>	4 <script src="../resources/testharnessreport.js"></script>

5 <script src="media-file.js"></script>	5 <script src="media-file.js"></script>

6 <script src="media-controls.js"></script>	6 <script src="media-controls.js"></script>

7 <!-- TODO(foolip): Convert test to testharness.js. crbug.com/588956	7 <audio controls></audio>

8 (Please avoid writing new tests using video-test.js) -->	8 <script>

9 <script src="video-test.js"></script>	9 async_test(function(t) {

10 </head>	10 var audio = document.querySelector("audio");

11 <body>	11 audio.src = findMediaFile("audio", "content/test");

12 <audio controls></audio>	12 assert_equals(audio.volume, 1);

13 <script>

14 findMediaElement();

15 audio.src = findMediaFile("audio", "content/test");

16 testExpected("audio.volume", 1);

17 waitForEvent("loadedmetadata", function()

18 {

19 // Focus the volume slider.

20 var button = mediaControlsButton(audio, "volume-slider");

21 button.focus();

22	13

23 // 'Left' reduces volume.	14 audio.onloadedmetadata = t.step_func(function() {

24 eventSender.keyDown('leftArrow');	15 // Focus the volume slider.

25 testExpected("audio.volume", 1, '<');	16 var button = mediaControlsButton(audio, "volume-slider");

	17 button.focus();
	fs 2016/05/29 14:52:43 Nit: These two lines could be merged. Nit: These two lines could be merged. Srirama 2016/05/30 07:55:14 Done. Show quoted text On 2016/05/29 14:52:43, fs wrote: > Nit: These two lines could be merged. Done.
26	18

27 // 'Right' reduces volume (same step as 'Left', but opposite sig n).	19 // 'Left' reduces volume.

28 eventSender.keyDown('rightArrow');	20 eventSender.keyDown("leftArrow");

29 testExpected("audio.volume", 1);	21 assert_less_than(audio.volume, 1);

30	22

31 // 'Home' sets minimum volume (0).	23 // 'Right' increases volume (same step as 'Left', but opposite sign).

32 eventSender.keyDown('home');	24 eventSender.keyDown("rightArrow");

33 testExpected("audio.volume", 0);	25 assert_equals(audio.volume, 1);

34	26

35 // 'End' sets maximum volume (1).	27 // 'Home' sets minimum volume (0).

36 eventSender.keyDown('end');	28 eventSender.keyDown("home");

37 testExpected("audio.volume", 1);	29 assert_equals(audio.volume, 0);

38	30

39 waitForEventAndEnd("volumechange");	31 // 'End' sets maximum volume (1).

40 });	32 eventSender.keyDown("end");

41 </script>	33 assert_equals(audio.volume, 1);

42 </body>	34

43 </html>	35 audio.onvolumechange = t.step_func_done();

	36 });

	37 });

	38 </script>

OLD	NEW