Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(862)

Issue 2021683002: [css-grid] Positioned items can be placed on the implicit grid (Closed)

Created:
4 years, 6 months ago by Manuel Rego
Modified:
4 years, 6 months ago
CC:
chromium-reviews, jfernandez, szager+layoutwatch_chromium.org, zoltan1, svillar, blink-reviews-layout_chromium.org, pdr+renderingwatchlist_chromium.org, Manuel Rego, leviw+renderwatch, jchaffraix+rendering, blink-reviews, eae+blinkwatch
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[css-grid] Positioned items can be placed on the implicit grid The old code wrongly assumed that positioned items couldn't be placed on the implicit grid. However, the spec doesn't mention anything about this. The patch fixes this issue, so now positioned items can be actually placed on the implicit tracks. Updated the test to follow the expected behavior. BUG=615630 TEST=fast/css-grid-layout/grid-positioned-items-within-grid-implicit-track.html Committed: https://crrev.com/5583f72362240b14f4f29facb90a24cd6a1ef516 Cr-Commit-Position: refs/heads/master@{#396711}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -18 lines) Patch
M third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-positioned-items-within-grid-implicit-track.html View 9 chunks +9 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutGrid.cpp View 3 chunks +7 lines, -9 lines 0 comments Download

Messages

Total messages: 13 (5 generated)
Manuel Rego
4 years, 6 months ago (2016-05-28 14:52:01 UTC) #2
svillar
lgtm
4 years, 6 months ago (2016-05-30 07:29:54 UTC) #3
svillar
lgtm
4 years, 6 months ago (2016-05-30 07:29:57 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2021683002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2021683002/1
4 years, 6 months ago (2016-05-30 07:42:09 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/78554)
4 years, 6 months ago (2016-05-30 09:39:02 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2021683002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2021683002/1
4 years, 6 months ago (2016-05-30 09:53:47 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-05-30 11:29:58 UTC) #11
commit-bot: I haz the power
4 years, 6 months ago (2016-05-30 11:31:44 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5583f72362240b14f4f29facb90a24cd6a1ef516
Cr-Commit-Position: refs/heads/master@{#396711}

Powered by Google App Engine
This is Rietveld 408576698