cc: Make LayerTreeSettings have in-member initialization.

cc: Make LayerTreeSettings have in-member initialization.

This patch changes LayerTreeSettings from using an in-ctor
initialization to in-class initialization.

R=danakj@chromium.org
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Committed: https://crrev.com/51db06d62dc6a6a25f16be3ab52053f80abece9c
Cr-Commit-Position: refs/heads/master@{#396983}

[vmpstr, 2016-05-27 23:22:03]

Description was changed from

==========
cc: Make LayerTreeSettings have in-member initialization.

This patch changes LayerTreeSettings from using an in-ctor
initialization to in-class initialization.

R=danakj@chromium.org
==========

to

==========
cc: Make LayerTreeSettings have in-member initialization.

This patch changes LayerTreeSettings from using an in-ctor
initialization to in-class initialization.

R=danakj@chromium.org
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

[vmpstr, 2016-05-27 23:23:26]

Please take a look. I wasn't too sure about non-POD types, but I couldn't find
any styleguide part that prohibits it.

[danakj, 2016-05-31 20:28:58]

https://codereview.chromium.org/2021433005/diff/1/cc/trees/layer_tree_settings.h
File cc/trees/layer_tree_settings.h (right):

https://codereview.chromium.org/2021433005/diff/1/cc/trees/layer_tree_setting...
cc/trees/layer_tree_settings.h:8: #include <GLES2/gl2.h>
I think I prefer include "third_party/khronos/GLES2/gl2.h" so it is easier to
tell where the file is. We're a bit inconsistent in this.

https://codereview.chromium.org/2021433005/diff/1/cc/trees/layer_tree_setting...
cc/trees/layer_tree_settings.h:75: gfx::Size default_tile_size = gfx::Size(256,
256);
This does compile as a copy. But we make these LayerTreeSettings rarely, and
none of these are move-only.. (I know cuz I tried to do this with a moveonly
thing once). Maybe if the constructor was a constexpr it would not copy. So I'm
a bit ambivalent about putting Size in the header, I wouldn't say it's good in
general but probly fine here.

https://codereview.chromium.org/2021433005/diff/1/cc/trees/layer_tree_setting...
cc/trees/layer_tree_settings.h:88:
std::vector<unsigned>(static_cast<size_t>(gfx::BufferFormat::LAST) + 1,
copying vectors tho seems like bad practice. I think this should stay in the .cc
file.

[vmpstr, 2016-05-31 21:01:43]

Moved non-PODs to .cc. PTAL.

https://codereview.chromium.org/2021433005/diff/1/cc/trees/layer_tree_settings.h
File cc/trees/layer_tree_settings.h (right):

https://codereview.chromium.org/2021433005/diff/1/cc/trees/layer_tree_setting...
cc/trees/layer_tree_settings.h:8: #include <GLES2/gl2.h>
On 2016/05/31 20:28:58, danakj wrote:
> I think I prefer include "third_party/khronos/GLES2/gl2.h" so it is easier to
> tell where the file is. We're a bit inconsistent in this.

Done.

https://codereview.chromium.org/2021433005/diff/1/cc/trees/layer_tree_setting...
cc/trees/layer_tree_settings.h:75: gfx::Size default_tile_size = gfx::Size(256,
256);
On 2016/05/31 20:28:58, danakj wrote:
> This does compile as a copy. 

It does?

> But we make these LayerTreeSettings rarely, and
> none of these are move-only.. (I know cuz I tried to do this with a moveonly
> thing once). Maybe if the constructor was a constexpr it would not copy. So
I'm
> a bit ambivalent about putting Size in the header, I wouldn't say it's good in
> general but probly fine here.

https://codereview.chromium.org/2021433005/diff/1/cc/trees/layer_tree_setting...
cc/trees/layer_tree_settings.h:88:
std::vector<unsigned>(static_cast<size_t>(gfx::BufferFormat::LAST) + 1,
On 2016/05/31 20:28:58, danakj wrote:
> copying vectors tho seems like bad practice. I think this should stay in the
.cc
> file.

I think this would be elided or at the very least moved.

[danakj, 2016-05-31 21:10:00]

LGTM

[vmpstr, 2016-05-31 21:34:02]

The CQ bit was checked by vmpstr@chromium.org

[commit-bot: I haz the power, 2016-05-31 21:34:28]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2021433005/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2021433005/60001

[commit-bot: I haz the power, 2016-05-31 23:59:39]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-06-01 00:01:30]

Description was changed from

==========
cc: Make LayerTreeSettings have in-member initialization.

This patch changes LayerTreeSettings from using an in-ctor
initialization to in-class initialization.

R=danakj@chromium.org
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

to

==========
cc: Make LayerTreeSettings have in-member initialization.

This patch changes LayerTreeSettings from using an in-ctor
initialization to in-class initialization.

R=danakj@chromium.org
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Committed: https://crrev.com/51db06d62dc6a6a25f16be3ab52053f80abece9c
Cr-Commit-Position: refs/heads/master@{#396983}
==========

[commit-bot: I haz the power, 2016-06-01 00:01:31]

Patchset 4 (id:??) landed as
https://crrev.com/51db06d62dc6a6a25f16be3ab52053f80abece9c
Cr-Commit-Position: refs/heads/master@{#396983}