Issue 202143009: Merge 168993 "Revert XMLHttpRequest's receive-as-blob implementa..."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 202143009: Merge 168993 "Revert XMLHttpRequest's receive-as-blob implementa..." (Closed)

Created:
6 years, 9 months ago by tyoshino (SeeGerritForStatus)

Modified:
6 years, 9 months ago

Reviewers:
tyoshino (SeeGerritForStatus)

CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, alph+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, aandrey+blink_chromium.org

Base URL:
svn://svn.chromium.org/blink/branches/chromium/1847/

Visibility:
Public.

More Reviews

Description

Merge 168993 "Revert XMLHttpRequest's receive-as-blob implementa..." > Revert XMLHttpRequest's receive-as-blob implementation back to use memory until Chromium is fixed > > The RedirectToFile functionality of Chromium on which the current > optimized [1] receive-as-blob code of XHR depends is broken. > Because of the bug, XHR::didDownloadData() handler may be invoked after > XHR::didFinishLoading(). See [2] for detail. As it seems the fix is not > ready for landing but the impact of the bug is big, I'd like to first > revert the optimization in Blink until Chromium is fixed well. > > [1] http://src.chromium.org/viewvc/blink?view=revision&revision=163141 > [2] https://codereview.chromium.org/82273002/ > > BUG=347663 > > Review URL: https://codereview.chromium.org/190583004 TBR=tyoshino@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=169409

Patch Set 1 #

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+14 lines, -53 lines)			Patch
M	LayoutTests/http/tests/inspector/network/network-xhr-async-response-type-blob-expected.txt	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/xml/XMLHttpRequest.h	View	2 chunks	+0 lines, -4 lines	0 comments	Download
M	Source/core/xml/XMLHttpRequest.cpp	View	8 chunks	+13 lines, -48 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

tyoshino (SeeGerritForStatus)

6 years, 9 months ago (2014-03-18 04:05:02 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 manually as r169409.

Expand Messages | Collapse Messages