Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1189)

Issue 190583004: Revert XMLHttpRequest's receive-as-blob implementation back to use memory until Chromium is fixed (Closed)

Created:
6 years, 9 months ago by tyoshino (SeeGerritForStatus)
Modified:
6 years, 9 months ago
CC:
blink-reviews
Visibility:
Public.

Description

Revert XMLHttpRequest's receive-as-blob implementation back to use memory until Chromium is fixed The RedirectToFile functionality of Chromium on which the current optimized [1] receive-as-blob code of XHR depends is broken. Because of the bug, XHR::didDownloadData() handler may be invoked after XHR::didFinishLoading(). See [2] for detail. As it seems the fix is not ready for landing but the impact of the bug is big, I'd like to first revert the optimization in Blink until Chromium is fixed well. [1] http://src.chromium.org/viewvc/blink?view=revision&revision=163141 [2] https://codereview.chromium.org/82273002/ BUG=347663 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=168993

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : http/tests/inspector/network/network-xhr-async-response-type-blob.html expectation update #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -53 lines) Patch
M LayoutTests/http/tests/inspector/network/network-xhr-async-response-type-blob-expected.txt View 1 2 1 chunk +1 line, -1 line 0 comments Download
M Source/core/xml/XMLHttpRequest.h View 2 chunks +0 lines, -4 lines 0 comments Download
M Source/core/xml/XMLHttpRequest.cpp View 1 8 chunks +12 lines, -48 lines 0 comments Download

Messages

Total messages: 23 (0 generated)
tyoshino (SeeGerritForStatus)
6 years, 9 months ago (2014-03-10 05:55:57 UTC) #1
abarth-chromium
Ok. LGTM
6 years, 9 months ago (2014-03-10 21:28:35 UTC) #2
abarth-chromium
The CQ bit was checked by abarth@chromium.org
6 years, 9 months ago (2014-03-10 21:28:38 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tyoshino@chromium.org/190583004/10001
6 years, 9 months ago (2014-03-10 21:29:01 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-10 22:10:36 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: mac_blink_rel
6 years, 9 months ago (2014-03-10 22:10:37 UTC) #6
tyoshino (SeeGerritForStatus)
Forgot to update the expectation for http/tests/inspector/network/network-xhr-async-response-type-blob.html. To do the optimization, we stopped passing the ...
6 years, 9 months ago (2014-03-11 02:16:11 UTC) #7
tyoshino (SeeGerritForStatus)
6 years, 9 months ago (2014-03-11 02:17:03 UTC) #8
tyoshino (SeeGerritForStatus)
The CQ bit was checked by tyoshino@chromium.org
6 years, 9 months ago (2014-03-11 15:27:17 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tyoshino@chromium.org/190583004/30001
6 years, 9 months ago (2014-03-11 15:27:27 UTC) #10
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-11 16:38:33 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: linux_blink
6 years, 9 months ago (2014-03-11 16:38:33 UTC) #12
tyoshino (SeeGerritForStatus)
The CQ bit was checked by tyoshino@chromium.org
6 years, 9 months ago (2014-03-11 16:41:39 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tyoshino@chromium.org/190583004/30001
6 years, 9 months ago (2014-03-11 16:41:53 UTC) #14
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-11 17:57:03 UTC) #15
commit-bot: I haz the power
Try jobs failed on following builders: linux_blink
6 years, 9 months ago (2014-03-11 17:57:06 UTC) #16
tyoshino (SeeGerritForStatus)
The CQ bit was checked by tyoshino@chromium.org
6 years, 9 months ago (2014-03-12 00:31:26 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tyoshino@chromium.org/190583004/30001
6 years, 9 months ago (2014-03-12 00:31:37 UTC) #18
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-12 05:08:47 UTC) #19
commit-bot: I haz the power
Try jobs failed on following builders: linux_blink
6 years, 9 months ago (2014-03-12 05:08:48 UTC) #20
tyoshino (SeeGerritForStatus)
The CQ bit was checked by tyoshino@chromium.org
6 years, 9 months ago (2014-03-12 05:12:01 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tyoshino@chromium.org/190583004/30001
6 years, 9 months ago (2014-03-12 05:12:08 UTC) #22
commit-bot: I haz the power
6 years, 9 months ago (2014-03-12 08:02:24 UTC) #23
Message was sent while issue was closed.
Change committed as 168993

Powered by Google App Engine
This is Rietveld 408576698