Move Blink dependency out of plugin proxy code.

Move Blink dependency out of plugin proxy code.
Moves dependency on WebSocket.h from plugin to host.

BUG=350097
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=257796

[bbudge, 2014-03-18 17:41:41]

This was motivated by jamesr who needed to patch our ppapi_internal target:
https://codereview.chromium.org/202523003/

[dmichael (off chromium), 2014-03-18 18:02:29]

lgtm, just nits. And... a special request (sorry)

https://codereview.chromium.org/202143007/diff/20001/content/renderer/pepper/...
File content/renderer/pepper/pepper_websocket_host.cc (right):

https://codereview.chromium.org/202143007/diff/20001/content/renderer/pepper/...
content/renderer/pepper/pepper_websocket_host.cc:258:
static_cast<blink::WebSocket::CloseEventCode>(code);
:-/
I like for us to do a compile assert on enum values that we convert this way, so
that we catch it right away if anything ever changes...

E.g.:
https://code.google.com/p/chromium/codesearch#chromium/src/content/renderer/p...

Would you be willing to add that? Separate CL would also be fine.

https://codereview.chromium.org/202143007/diff/20001/ppapi/proxy/websocket_re...
File ppapi/proxy/websocket_resource.cc (right):

https://codereview.chromium.org/202143007/diff/20001/ppapi/proxy/websocket_re...
ppapi/proxy/websocket_resource.cc:140: if ((code !=
PP_WEBSOCKETSTATUSCODE_NORMAL_CLOSURE &&
nit: I think you have an extra set of enclosing parens

https://codereview.chromium.org/202143007/diff/20001/ppapi/proxy/websocket_re...
ppapi/proxy/websocket_resource.cc:141:
(PP_WEBSOCKETSTATUSCODE_USER_REGISTERED_MIN > code ||
nit: now that you negated this, I think it would be more readable to reverse
these:
code < PP_WEBSOCKETSTATUSCODE_USER_REGISTERED_MIN

[bbudge, 2014-03-18 20:23:31]

https://codereview.chromium.org/202143007/diff/20001/content/renderer/pepper/...
File content/renderer/pepper/pepper_websocket_host.cc (right):

https://codereview.chromium.org/202143007/diff/20001/content/renderer/pepper/...
content/renderer/pepper/pepper_websocket_host.cc:258:
static_cast<blink::WebSocket::CloseEventCode>(code);
On 2014/03/18 18:02:30, dmichael wrote:
> :-/
> I like for us to do a compile assert on enum values that we convert this way,
so
> that we catch it right away if anything ever changes...
> 
> E.g.:
>
https://code.google.com/p/chromium/codesearch#chromium/src/content/renderer/p...
> 
> Would you be willing to add that? Separate CL would also be fine.

Done.

https://codereview.chromium.org/202143007/diff/20001/ppapi/proxy/websocket_re...
File ppapi/proxy/websocket_resource.cc (right):

https://codereview.chromium.org/202143007/diff/20001/ppapi/proxy/websocket_re...
ppapi/proxy/websocket_resource.cc:140: if ((code !=
PP_WEBSOCKETSTATUSCODE_NORMAL_CLOSURE &&
On 2014/03/18 18:02:30, dmichael wrote:
> nit: I think you have an extra set of enclosing parens

Done.

https://codereview.chromium.org/202143007/diff/20001/ppapi/proxy/websocket_re...
ppapi/proxy/websocket_resource.cc:141:
(PP_WEBSOCKETSTATUSCODE_USER_REGISTERED_MIN > code ||
On 2014/03/18 18:02:30, dmichael wrote:
> nit: now that you negated this, I think it would be more readable to reverse
> these:
> code < PP_WEBSOCKETSTATUSCODE_USER_REGISTERED_MIN

Done. (Just reversed the first, is that what you meant?)

[bbudge, 2014-03-18 20:25:53]

The CQ bit was checked by bbudge@chromium.org

[commit-bot: I haz the power, 2014-03-18 20:28:08]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/bbudge@chromium.org/202143007/40001

[dmichael (off chromium), 2014-03-18 20:38:53]

still lgtm, thanks for doing the compile asserts!

https://codereview.chromium.org/202143007/diff/20001/ppapi/proxy/websocket_re...
File ppapi/proxy/websocket_resource.cc (right):

https://codereview.chromium.org/202143007/diff/20001/ppapi/proxy/websocket_re...
ppapi/proxy/websocket_resource.cc:141:
(PP_WEBSOCKETSTATUSCODE_USER_REGISTERED_MIN > code ||
On 2014/03/18 20:23:31, bbudge wrote:
> On 2014/03/18 18:02:30, dmichael wrote:
> > nit: now that you negated this, I think it would be more readable to reverse
> > these:
> > code < PP_WEBSOCKETSTATUSCODE_USER_REGISTERED_MIN
> 
> Done. (Just reversed the first, is that what you meant?)
Yes, that's exactly what I meant, thanks!

[commit-bot: I haz the power, 2014-03-18 22:51:35]

Change committed as 257796