Move Blink dependency out of plugin proxy code.

content/renderer/pepper/pepper_websocket_host.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/renderer/pepper/pepper_websocket_host.h"
 
 #include <string>
 
 #include "content/public/renderer/renderer_ppapi_host.h"
 #include "net/base/net_util.h"
@@ skipping 235 matching lines @@
 }
 
 int32_t PepperWebSocketHost::OnHostMsgClose(
     ppapi::host::HostMessageContext* context,
     int32_t code,
     const std::string& reason) {
   if (!websocket_)
     return PP_ERROR_FAILED;
   close_reply_ = context->MakeReplyMessageContext();
   initiating_close_ = true;
+
+  blink::WebSocket::CloseEventCode event_code =
+    static_cast<blink::WebSocket::CloseEventCode>(code);

[dmichael (off chromium), 2014/03/18 18:02:30]

:-/
I like for us to do a compile assert on enum values that we convert this way, so
that we catch it right away if anything ever changes...

E.g.:
https://code.google.com/p/chromium/codesearch#chromium/src/content/renderer/p...

Would you be willing to add that? Separate CL would also be fine.

[bbudge, 2014/03/18 20:23:31]

Done.

+  if (code == PP_WEBSOCKETSTATUSCODE_NOT_SPECIFIED) {
+    // PP_WEBSOCKETSTATUSCODE_NOT_SPECIFIED and CloseEventCodeNotSpecified are
+    // assigned to different values. A conversion is needed if
+    // PP_WEBSOCKETSTATUSCODE_NOT_SPECIFIED is specified.
+    event_code = blink::WebSocket::CloseEventCodeNotSpecified;
+  }
+
   WebString web_reason = WebString::fromUTF8(reason);
-  websocket_->close(code, web_reason);
+  websocket_->close(event_code, web_reason);
   return PP_OK_COMPLETIONPENDING;
 }
 
 int32_t PepperWebSocketHost::OnHostMsgSendText(
     ppapi::host::HostMessageContext* context,
     const std::string& message) {
   if (websocket_) {
     WebString web_message = WebString::fromUTF8(message);
     websocket_->sendText(web_message);
   }
@@ skipping 13 matching lines @@
 
 int32_t PepperWebSocketHost::OnHostMsgFail(
     ppapi::host::HostMessageContext* context,
     const std::string& message) {
   if (websocket_)
     websocket_->fail(WebString::fromUTF8(message));
   return PP_OK;
 }
 
 }  // namespace content