Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Issue 2021413003: Remove GL_CHROMIUM_iosurface extension (Closed)

Created:
4 years, 6 months ago by ccameron
Modified:
4 years, 6 months ago
Reviewers:
raymes, piman
CC:
chromium-reviews, rjkroege, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, piman+watch_chromium.org, cc-bugs_chromium.org, ben+mojo_chromium.org, darin (slow to review)
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove GL_CHROMIUM_iosurface extension It has not been used in a long time. IOSurface-backed textures are created via GpuMemoryBuffer and GLImage infrastructure. BUG= CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel NOPRESUBMIT=true Committed: https://crrev.com/a55c2859597c6377c6b1d01dfc7cf14d87fed81b Cr-Commit-Position: refs/heads/master@{#397257}

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+64 lines, -494 lines) Patch
M cc/resources/resource_provider.h View 1 chunk +0 lines, -4 lines 0 comments Download
M cc/resources/resource_provider.cc View 1 chunk +0 lines, -20 lines 0 comments Download
M cc/test/test_gles2_interface.h View 1 chunk +0 lines, -5 lines 0 comments Download
M cc/test/test_gles2_interface.cc View 1 chunk +0 lines, -9 lines 0 comments Download
M cc/test/test_web_graphics_context_3d.h View 1 chunk +0 lines, -6 lines 0 comments Download
M gpu/GLES2/gl2chromium_autogen.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M gpu/GLES2/gl2extchromium.h View 1 1 chunk +0 lines, -13 lines 0 comments Download
M gpu/command_buffer/build_gles2_cmd_buffer.py View 1 1 chunk +0 lines, -7 lines 0 comments Download
M gpu/command_buffer/client/gles2_c_lib_autogen.h View 1 2 chunks +0 lines, -12 lines 0 comments Download
M gpu/command_buffer/client/gles2_cmd_helper_autogen.h View 1 1 chunk +0 lines, -12 lines 0 comments Download
M gpu/command_buffer/client/gles2_implementation_autogen.h View 1 1 chunk +0 lines, -6 lines 0 comments Download
M gpu/command_buffer/client/gles2_implementation_impl_autogen.h View 1 1 chunk +0 lines, -23 lines 0 comments Download
M gpu/command_buffer/client/gles2_implementation_unittest_autogen.h View 1 1 chunk +0 lines, -11 lines 0 comments Download
M gpu/command_buffer/client/gles2_interface_autogen.h View 1 1 chunk +0 lines, -5 lines 0 comments Download
M gpu/command_buffer/client/gles2_interface_stub_autogen.h View 1 1 chunk +0 lines, -5 lines 0 comments Download
M gpu/command_buffer/client/gles2_interface_stub_impl_autogen.h View 1 1 chunk +0 lines, -5 lines 0 comments Download
M gpu/command_buffer/client/gles2_trace_implementation_autogen.h View 1 1 chunk +0 lines, -5 lines 0 comments Download
M gpu/command_buffer/client/gles2_trace_implementation_impl_autogen.h View 1 1 chunk +0 lines, -10 lines 0 comments Download
M gpu/command_buffer/cmd_buffer_functions.txt View 1 1 chunk +0 lines, -1 line 0 comments Download
M gpu/command_buffer/common/gles2_cmd_format_autogen.h View 1 1 chunk +0 lines, -59 lines 0 comments Download
M gpu/command_buffer/common/gles2_cmd_format_test_autogen.h View 1 1 chunk +0 lines, -17 lines 0 comments Download
M gpu/command_buffer/common/gles2_cmd_ids_autogen.h View 1 1 chunk +60 lines, -61 lines 0 comments Download
M gpu/command_buffer/service/feature_info.cc View 1 2 chunks +4 lines, -6 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder.cc View 1 6 chunks +0 lines, -129 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder_autogen.h View 1 chunk +0 lines, -30 lines 0 comments Download
M mojo/gpu/mojo_gles2_impl_autogen.h View 1 chunk +0 lines, -5 lines 0 comments Download
M mojo/gpu/mojo_gles2_impl_autogen.cc View 1 chunk +0 lines, -8 lines 0 comments Download
M ppapi/lib/gl/include/GLES2/gl2ext.h View 1 chunk +0 lines, -19 lines 0 comments Download

Messages

Total messages: 23 (12 generated)
ccameron
Leaning on the delete key.
4 years, 6 months ago (2016-06-01 00:59:10 UTC) #4
piman
LGTM, thanks tons for the cleanup!
4 years, 6 months ago (2016-06-01 01:33:20 UTC) #5
raymes
ppapi rubberstamp lgtm
4 years, 6 months ago (2016-06-01 01:33:47 UTC) #6
ccameron
Thanks! (hoping that the presubmit complaint about licenses won't cause problems)
4 years, 6 months ago (2016-06-01 01:57:39 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2021413003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2021413003/1
4 years, 6 months ago (2016-06-01 01:58:32 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/192637)
4 years, 6 months ago (2016-06-01 02:07:23 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2021413003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2021413003/1
4 years, 6 months ago (2016-06-01 19:34:04 UTC) #14
commit-bot: I haz the power
Failed to apply patch for gpu/command_buffer/common/gles2_cmd_ids_autogen.h: While running git apply --index -3 -p1; error: patch ...
4 years, 6 months ago (2016-06-01 19:35:20 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2021413003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2021413003/20001
4 years, 6 months ago (2016-06-01 19:53:48 UTC) #19
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 6 months ago (2016-06-01 21:40:18 UTC) #21
commit-bot: I haz the power
4 years, 6 months ago (2016-06-01 21:42:21 UTC) #23
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/a55c2859597c6377c6b1d01dfc7cf14d87fed81b
Cr-Commit-Position: refs/heads/master@{#397257}

Powered by Google App Engine
This is Rietveld 408576698