Issue 2021373003: Disable frame navigations during DocumentLoader detach in FrameLoader::startLoad

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2021373003: Disable frame navigations during DocumentLoader detach in FrameLoader::startLoad (Closed)

Created:
4 years, 9 months ago by Nate Chapin

Modified:
4 years, 9 months ago

Reviewers:

CC:
chromium-reviews

Base URL:
https://chromium.googlesource.com/chromium/src.git@2704

Target Ref:
refs/pending/branch-heads/2704

Project:
chromium

Visibility:
Public.

Disable frame navigations during DocumentLoader detach in FrameLoader::startLoad BUG=613266 Review-Url: https://codereview.chromium.org/2006033002 Cr-Commit-Position: refs/heads/master@{#396241} (cherry picked from commit 1948aefa8901dca0ccb993753fca00b15d2a6e25) Committed: https://chromium.googlesource.com/chromium/src/+/0a0e03cf8a52aab2ad2d1fe3bc0d3dcbe57911bd

Created: 4 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+34 lines, -1 line)			Patch
A	third_party/WebKit/LayoutTests/http/tests/navigation/start-load-during-provisional-loader-detach.html	View	1 chunk	+27 lines, -0 lines	0 comments	Download
A	third_party/WebKit/LayoutTests/http/tests/navigation/start-load-during-provisional-loader-detach-expected.txt	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	third_party/WebKit/Source/core/html/HTMLAnchorElement.cpp	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	third_party/WebKit/Source/core/loader/FrameLoader.cpp	View	1 chunk	+4 lines, -1 line	0 comments	Download

Total messages: 2 (1 generated)

Nate Chapin

4 years, 9 months ago (2016-05-31 22:10:41 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
0a0e03cf8a52aab2ad2d1fe3bc0d3dcbe57911bd.