Disable frame navigations during DocumentLoader detach in FrameLoader::startLoad

Disable frame navigations during DocumentLoader detach in FrameLoader::startLoad

BUG=613266
Committed: https://crrev.com/1948aefa8901dca0ccb993753fca00b15d2a6e25
Cr-Commit-Position: refs/heads/master@{#396241}

[Nate Chapin, 2016-05-24 23:36:20]

Description was changed from

==========
Call detachFromFrame() after clearing DocumentLoader pointer on FrameLoader

BUG=
==========

to

==========
Disable frame navigations during DocumentLoader detach in FrameLoader::startLoad

BUG=613266
==========

[Nate Chapin, 2016-05-25 21:55:47]

The CQ bit was checked by japhet@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-05-25 21:56:30]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2006033002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2006033002/80001

[Nate Chapin, 2016-05-25 23:03:07]

japhet@chromium.org changed reviewers:
+ dcheng@chromium.org

[Nate Chapin, 2016-05-25 23:03:08]

D:

https://codereview.chromium.org/2006033002/diff/80001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/http/tests/navigation/start-load-during-provisional-loader-detach.html
(right):

https://codereview.chromium.org/2006033002/diff/80001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/http/tests/navigation/start-load-during-provisional-loader-detach.html:11:
child.contentWindow.onload = function() {
This test fails without the FrameLoader.cpp change by crashing in
FrameLoader::commitProvisionalLoad due to m_provisionalDocumentLoader being
null. The repro in the bug calls stop(), but that makes the test a lot more
complicated to run automatically: it requires a waitUntilDone(), and there isn't
a place to call notifyDone() that works both with and without the bugfix.

[commit-bot: I haz the power, 2016-05-26 01:04:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-26 01:04:38]

Dry run: This issue passed the CQ dry run.

[commit-bot: I haz the power, 2016-05-26 01:04:58]

Dry run: None

[dcheng, 2016-05-26 17:32:13]

lgtm

Out of curiosity, will you try to make it go through NavigationScheduler in a
followup?

[Nate Chapin, 2016-05-26 17:41:58]

On 2016/05/26 17:32:13, dcheng wrote:
> lgtm
> 
> Out of curiosity, will you try to make it go through NavigationScheduler in a
> followup?

I hope so. See patchset 4 for how that went on my first attempt :/

[Nate Chapin, 2016-05-26 18:37:20]

The CQ bit was checked by japhet@chromium.org

[commit-bot: I haz the power, 2016-05-26 18:38:20]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2006033002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2006033002/80001

[commit-bot: I haz the power, 2016-05-26 18:43:09]

Description was changed from

==========
Disable frame navigations during DocumentLoader detach in FrameLoader::startLoad

BUG=613266
==========

to

==========
Disable frame navigations during DocumentLoader detach in FrameLoader::startLoad

BUG=613266
==========

[commit-bot: I haz the power, 2016-05-26 18:43:10]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-05-26 18:44:20]

Description was changed from

==========
Disable frame navigations during DocumentLoader detach in FrameLoader::startLoad

BUG=613266
==========

to

==========
Disable frame navigations during DocumentLoader detach in FrameLoader::startLoad

BUG=613266

Committed: https://crrev.com/1948aefa8901dca0ccb993753fca00b15d2a6e25
Cr-Commit-Position: refs/heads/master@{#396241}
==========

[commit-bot: I haz the power, 2016-05-26 18:44:21]

Patchset 5 (id:??) landed as
https://crrev.com/1948aefa8901dca0ccb993753fca00b15d2a6e25
Cr-Commit-Position: refs/heads/master@{#396241}