Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2021283002:
[Android] Remove connectivity change logging from NetworkChangeNotifierAutoDetect. (Closed)
|
Created:
4 years, 6 months ago by timvolodine Modified:
3 years, 10 months ago CC:
chromium-reviews, cbentzel+watch_chromium.org Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
Description[Android] Remove connectivity change logging from NetworkChangeNotifierAutoDetect.
Currently the java debug logs cannot be stripped out in webview and
hence this results in 'spammy' log every time the connectivity
changes.
BUG=614066
Review-Url: https://codereview.chromium.org/2021283002
Cr-Commit-Position: refs/heads/master@{#450683}
Committed: https://chromium.googlesource.com/chromium/src/+/3b2f56255b45fa7183f6048647b341db4b3fd50e
Patch Set 1 #Patch Set 2 : rebase #Messages
Total messages: 21 (8 generated)
timvolodine@chromium.org changed reviewers: + torne@chromium.org
lgtm
Are you going to land this, Tim?
yeah the reason it got stuck is that I was unsure if we actually wanted to remove this logging due to outstanding issues with network stack (e.g. crbug.com/591959). That logging would potentially make it easier to debug... dunno though. On Tue, Sep 13, 2016 at 3:56 PM, <torne@chromium.org> wrote: > Are you going to land this, Tim? > > https://codereview.chromium.org/2021283002/ > -- You received this message because you are subscribed to the Google Groups "Chromium-reviews" group. To unsubscribe from this group and stop receiving emails from it, send an email to chromium-reviews+unsubscribe@chromium.org.
We're actually stripping debug level logs with proguard now, I think, so the spam here may already be gone - but in any case, it sounds like this logging is redundant with native logging, and it won't be there in release builds anyway due to proguard, so maybe we should jsut delete it anyhow?
I think we can just go ahead and land this?
On 2017/02/13 11:12:00, Torne wrote: > I think we can just go ahead and land this? Okay discussed this offline. It appears this logging is still there in release build, filed crbug.com/692106 to track that. We have similar vlog(1) level logging in logging_network_change_observer.cc which can be used for debugging. In addition to that the current logging uses android.util.Log which is not the recommended chromium logging. So given all this will land this patch.
The CQ bit was checked by timvolodine@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from torne@chromium.org Link to the patchset: https://codereview.chromium.org/2021283002/#ps20001 (title: "rebase")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
timvolodine@chromium.org changed reviewers: + pauljensen@chromium.org
+pauljensen@ as OWNER PTAL
The CQ bit was checked by pauljensen@chromium.org
lgtm
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1487164256170990,
"parent_rev": "b17d9a4856f90d8faaa6380cfa9cbbf946af10c6", "commit_rev":
"3b2f56255b45fa7183f6048647b341db4b3fd50e"}
Message was sent while issue was closed.
Description was changed from ========== [Android] Remove connectivity change logging from NetworkChangeNotifierAutoDetect. Currently the java debug logs cannot be stripped out in webview and hence this results in 'spammy' log every time the connectivity changes. BUG=614066 ========== to ========== [Android] Remove connectivity change logging from NetworkChangeNotifierAutoDetect. Currently the java debug logs cannot be stripped out in webview and hence this results in 'spammy' log every time the connectivity changes. BUG=614066 Review-Url: https://codereview.chromium.org/2021283002 Cr-Commit-Position: refs/heads/master@{#450683} Committed: https://chromium.googlesource.com/chromium/src/+/3b2f56255b45fa7183f6048647b3... ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/src/+/3b2f56255b45fa7183f6048647b3... |
