Chromium Code Reviews
DescriptionRevert of Pseudo and non pseudo elements should return correct computed content value (patchset #14 id:260001 of https://codereview.chromium.org/1812763002/ )
Reason for revert:
BUG=609848
A lot of sites in production are depending on content returning an empty string.
Original issue's description:
> Pseudo and non pseudo elements should return correct computed content value
>
> This patch makes sure that content computes to "normal" for elements
> (not pseudo elements) and to "none" if the specified value of pseudo
> elements ::before and ::after is "normal."
>
> This patch makes us interoperable with all other browsers for the
> case of pseudo elements :before and ::after where the specified value
> is "normal".
>
> With regards to non psuedo elements we are now interoperable with IE
> and the spec and return "normal" for the computed content all all non
> psuedo elements.
> Other browsers are inconcistent on this behaviour:
> 1. Edge returns an empty string for non pseudo elements
> 2. FF returns none for non pseudo elements.
>
> The spec implemented is given here:
> https://drafts.csswg.org/css2/generate.html#content
>
> BUG=597500
>
> Committed: https://crrev.com/aaeefae6c3a945e7fcfef382c3a82002ffae0e19
> Cr-Commit-Position: refs/heads/master@{#383949}
TBR=alancutter@chromium.org,timloh@chromium.org
BUG=597500
Review-Url: https://codereview.chromium.org/1977323002
Cr-Commit-Position: refs/heads/master@{#394729}
(cherry picked from commit bd9df7c452f9a6aadc49214a4a09451fc726be92)
Committed: https://chromium.googlesource.com/chromium/src/+/7597d46261e696554606f4ed3d0931147cc2d1ba
Patch Set 1 #Messages
Total messages: 2 (1 generated)
|