Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(142)

Issue 2021163002: Revert of Pseudo and non pseudo elements should return correct computed content value (patchset #14… (Closed)

Created:
4 years, 6 months ago by alancutter (OOO until 2018)
Modified:
4 years, 6 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2704
Target Ref:
refs/pending/branch-heads/2704
Project:
chromium
Visibility:
Public.

Description

Revert of Pseudo and non pseudo elements should return correct computed content value (patchset #14 id:260001 of https://codereview.chromium.org/1812763002/ ) Reason for revert: BUG=609848 A lot of sites in production are depending on content returning an empty string. Original issue's description: > Pseudo and non pseudo elements should return correct computed content value > > This patch makes sure that content computes to "normal" for elements > (not pseudo elements) and to "none" if the specified value of pseudo > elements ::before and ::after is "normal." > > This patch makes us interoperable with all other browsers for the > case of pseudo elements :before and ::after where the specified value > is "normal". > > With regards to non psuedo elements we are now interoperable with IE > and the spec and return "normal" for the computed content all all non > psuedo elements. > Other browsers are inconcistent on this behaviour: > 1. Edge returns an empty string for non pseudo elements > 2. FF returns none for non pseudo elements. > > The spec implemented is given here: > https://drafts.csswg.org/css2/generate.html#content > > BUG=597500 > > Committed: https://crrev.com/aaeefae6c3a945e7fcfef382c3a82002ffae0e19 > Cr-Commit-Position: refs/heads/master@{#383949} TBR=alancutter@chromium.org,timloh@chromium.org BUG=597500 Review-Url: https://codereview.chromium.org/1977323002 Cr-Commit-Position: refs/heads/master@{#394729} (cherry picked from commit bd9df7c452f9a6aadc49214a4a09451fc726be92) Committed: https://chromium.googlesource.com/chromium/src/+/7597d46261e696554606f4ed3d0931147cc2d1ba

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+122 lines, -176 lines) Patch
M third_party/WebKit/LayoutTests/css3/supports.html View 6 chunks +54 lines, -56 lines 0 comments Download
M third_party/WebKit/LayoutTests/css3/supports-expected.txt View 1 chunk +48 lines, -48 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/css/content-property-quote-types.html View 1 chunk +5 lines, -5 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/css/getComputedStyle/computed-style-listing-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/fast/css/getComputedStyle/computed-style-without-renderer-listing-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
D third_party/WebKit/LayoutTests/fast/css/getComputedStyle/getComputedStyle-content.html View 1 chunk +0 lines, -48 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/css/nested-at-rules.html View 4 chunks +5 lines, -5 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/css/nested-at-rules-expected.txt View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/dom/hover-after-dom-delete.html View 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/dom/hover-after-dom-delete-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/inspector/elements/elements-panel-styles-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/svg/css/getComputedStyle-listing-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/css/ComputedStyleCSSValueMapping.cpp View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
alancutter (OOO until 2018)
4 years, 6 months ago (2016-05-31 01:28:12 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
7597d46261e696554606f4ed3d0931147cc2d1ba.

Powered by Google App Engine
This is Rietveld 408576698