Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(322)

Issue 1977323002: Revert of Pseudo and non pseudo elements should return correct computed content value (Closed)

Created:
4 years, 7 months ago by nainar
Modified:
4 years, 7 months ago
Reviewers:
Timothy Loh
CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-css, blink-reviews-style_chromium.org, chromium-reviews, dglazkov+blink, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Pseudo and non pseudo elements should return correct computed content value (patchset #14 id:260001 of https://codereview.chromium.org/1812763002/ ) Reason for revert: BUG=609848 A lot of sites in production are depending on content returning an empty string. Original issue's description: > Pseudo and non pseudo elements should return correct computed content value > > This patch makes sure that content computes to "normal" for elements > (not pseudo elements) and to "none" if the specified value of pseudo > elements ::before and ::after is "normal." > > This patch makes us interoperable with all other browsers for the > case of pseudo elements :before and ::after where the specified value > is "normal". > > With regards to non psuedo elements we are now interoperable with IE > and the spec and return "normal" for the computed content all all non > psuedo elements. > Other browsers are inconcistent on this behaviour: > 1. Edge returns an empty string for non pseudo elements > 2. FF returns none for non pseudo elements. > > The spec implemented is given here: > https://drafts.csswg.org/css2/generate.html#content > > BUG=597500 > > Committed: https://crrev.com/aaeefae6c3a945e7fcfef382c3a82002ffae0e19 > Cr-Commit-Position: refs/heads/master@{#383949} TBR=alancutter@chromium.org,timloh@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=597500 Committed: https://crrev.com/bd9df7c452f9a6aadc49214a4a09451fc726be92 Cr-Commit-Position: refs/heads/master@{#394729}

Patch Set 1 #

Patch Set 2 : Rebased manually #

Total comments: 2

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+122 lines, -176 lines) Patch
M third_party/WebKit/LayoutTests/css3/supports.html View 1 2 6 chunks +54 lines, -56 lines 0 comments Download
M third_party/WebKit/LayoutTests/css3/supports-expected.txt View 1 1 chunk +48 lines, -48 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/css/content-property-quote-types.html View 1 1 chunk +5 lines, -5 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/css/getComputedStyle/computed-style-listing-expected.txt View 1 2 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/fast/css/getComputedStyle/computed-style-without-renderer-listing-expected.txt View 1 2 1 chunk +1 line, -1 line 0 comments Download
D third_party/WebKit/LayoutTests/fast/css/getComputedStyle/getComputedStyle-content.html View 1 chunk +0 lines, -48 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/css/nested-at-rules.html View 1 4 chunks +5 lines, -5 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/css/nested-at-rules-expected.txt View 1 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/dom/hover-after-dom-delete.html View 1 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/dom/hover-after-dom-delete-expected.txt View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/inspector/elements/elements-panel-styles-expected.txt View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/svg/css/getComputedStyle-listing-expected.txt View 1 2 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/css/ComputedStyleCSSValueMapping.cpp View 1 2 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 14 (4 generated)
nainar
Created Revert of Pseudo and non pseudo elements should return correct computed content value
4 years, 7 months ago (2016-05-16 05:31:55 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1977323002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1977323002/1
4 years, 7 months ago (2016-05-16 05:32:07 UTC) #2
commit-bot: I haz the power
Try jobs failed on following builders: ios-device-gn on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-gn/builds/5940) ios-simulator on tryserver.chromium.mac (JOB_FAILED, ...
4 years, 7 months ago (2016-05-16 05:33:35 UTC) #4
nainar
PTAL?
4 years, 7 months ago (2016-05-16 05:54:27 UTC) #6
Timothy Loh
https://codereview.chromium.org/1977323002/diff/240001/third_party/WebKit/LayoutTests/css3/supports.html File third_party/WebKit/LayoutTests/css3/supports.html (right): https://codereview.chromium.org/1977323002/diff/240001/third_party/WebKit/LayoutTests/css3/supports.html#newcode213 third_party/WebKit/LayoutTests/css3/supports.html:213: #t43 { background-color: red; } why didn't this change ...
4 years, 7 months ago (2016-05-18 05:42:10 UTC) #7
nainar
https://codereview.chromium.org/1977323002/diff/240001/third_party/WebKit/LayoutTests/css3/supports.html File third_party/WebKit/LayoutTests/css3/supports.html (right): https://codereview.chromium.org/1977323002/diff/240001/third_party/WebKit/LayoutTests/css3/supports.html#newcode213 third_party/WebKit/LayoutTests/css3/supports.html:213: #t43 { background-color: red; } This was a manual ...
4 years, 7 months ago (2016-05-19 00:04:39 UTC) #8
Timothy Loh
lgtm
4 years, 7 months ago (2016-05-19 08:44:48 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1977323002/260001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1977323002/260001
4 years, 7 months ago (2016-05-19 09:04:41 UTC) #11
commit-bot: I haz the power
Committed patchset #3 (id:260001)
4 years, 7 months ago (2016-05-19 10:49:25 UTC) #12
commit-bot: I haz the power
4 years, 7 months ago (2016-05-19 10:51:45 UTC) #14
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/bd9df7c452f9a6aadc49214a4a09451fc726be92
Cr-Commit-Position: refs/heads/master@{#394729}

Powered by Google App Engine
This is Rietveld 408576698