Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Issue 2021133003: Revert "Introduces "--initializing-formal-access"." (Closed)

Created:
4 years, 6 months ago by eernst
Modified:
4 years, 6 months ago
Reviewers:
Johnni Winther
CC:
reviews_dartlang.org, floitsch
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Revert "Introduces "--initializing-formal-access"." This reverts commit b80a73775cb1ba2539667a067ce608485cc136b7 because introduced new failures in co19 tests. Committed: https://github.com/dart-lang/sdk/commit/5b72755837f60e67ce492c970c214c7b791be2dd

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -76 lines) Patch
M pkg/compiler/lib/src/commandline_options.dart View 1 chunk +0 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/compile_time_constants.dart View 1 chunk +0 lines, -3 lines 0 comments Download
M pkg/compiler/lib/src/dart2js.dart View 1 chunk +0 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/diagnostics/messages.dart View 1 chunk +0 lines, -9 lines 0 comments Download
M pkg/compiler/lib/src/elements/elements.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/elements/modelx.dart View 1 chunk +1 line, -5 lines 0 comments Download
M pkg/compiler/lib/src/options.dart View 5 chunks +0 lines, -9 lines 0 comments Download
M pkg/compiler/lib/src/resolution/members.dart View 3 chunks +1 line, -8 lines 0 comments Download
M pkg/compiler/lib/src/typechecker.dart View 1 chunk +1 line, -4 lines 0 comments Download
D tests/language/initializing_formal_access_test.dart View 1 chunk +0 lines, -28 lines 0 comments Download
M tests/language/language.status View 1 chunk +0 lines, -3 lines 0 comments Download
M tests/language/language_analyzer2.status View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
eernst
A revert, TBR.
4 years, 6 months ago (2016-05-31 16:02:47 UTC) #2
eernst
Committed patchset #1 (id:1) manually as 5b72755837f60e67ce492c970c214c7b791be2dd (presubmit successful).
4 years, 6 months ago (2016-05-31 16:03:28 UTC) #4
Johnni Winther
4 years, 6 months ago (2016-06-02 07:34:58 UTC) #5
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698