Revert "Introduces "--initializing-formal-access"."

pkg/compiler/lib/src/elements/elements.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library elements;
 
 import '../common.dart';
 import '../common/resolution.dart' show Resolution;
 import '../compiler.dart' show Compiler;
 import '../constants/constructors.dart';
@@ skipping 1049 matching lines @@
   /// this parameter is declared.
   FunctionTypedElement get functionDeclaration;
 
   VariableDefinitions get node;
 }
 
 /// A formal parameter of a function or constructor.
 ///
 /// Normal parameter that introduce a local variable are modeled by
 /// [LocalParameterElement] whereas initializing formals, that is parameter of
-/// the form `this.x`, are modeled by [InitializingFormalElement].
+/// the form `this.x`, are modeled by [InitializingFormalParameter].
 abstract class ParameterElement extends Element
     implements VariableElement, FormalElement, LocalElement {
   /// Use [functionDeclaration] instead.
   @deprecated
   get enclosingElement;
 
   /// The function on which this parameter is declared.
   FunctionElement get functionDeclaration;
 
   /// `true` if this parameter is named.
   bool get isNamed;
 
   /// `true` if this parameter is optional.
   bool get isOptional;
 }
 
 /// A formal parameter on a function or constructor that introduces a local
 /// variable in the scope of the function or constructor.
 abstract class LocalParameterElement extends ParameterElement
     implements LocalVariableElement {}
 
 /// A formal parameter in a constructor that directly initializes a field.
 ///
 /// For example: `A(this.field)`.
-abstract class InitializingFormalElement extends LocalParameterElement {
+abstract class InitializingFormalElement extends ParameterElement {
   /// The field initialized by this initializing formal.
   FieldElement get fieldElement;
 
   /// The function on which this parameter is declared.
   ConstructorElement get functionDeclaration;
 }
 
 /**
  * A synthetic element which holds a getter and/or a setter.
  *
@@ skipping 724 matching lines @@
   /// by a field.
   bool get isDeclaredByField;
 
   /// Returns `true` if this member is abstract.
   bool get isAbstract;
 
   /// If abstract, [implementation] points to the overridden concrete member,
   /// if any. Otherwise [implementation] points to the member itself.
   Member get implementation;
 }