Use ChannelMojo for pepper plugin processes.

Use ChannelMojo for pepper plugin processes.

BUG=604282
Committed: https://crrev.com/80ce6dc508ddba8c32c4b5f958bc558b32c427d6
Cr-Commit-Position: refs/heads/master@{#398420}

[Anand Mistry (off Chromium), 2016-06-03 01:19:15]

amistry@chromium.org changed reviewers:
+ dcheng@chromium.org, nick@chromium.org

[Anand Mistry (off Chromium), 2016-06-03 01:19:16]

nick: for content/ owners
dcheng: in case there are any security concerns about using ChannelMojo in wider
contexts

[dcheng, 2016-06-03 04:40:05]

dcheng@chromium.org changed reviewers:
+ tsepez@chromium.org
- dcheng@chromium.org

[dcheng, 2016-06-03 04:40:06]

This is just part of the general desire to migrate from IPC::Channel to
IPC::ChannelMojo right?

Is there anything particular to know about IPC::ChannelMojo in terms of
differences? Obviously it supports Mojo. There's a bit of a performance cost as
well, right? Anything else to be aware of?

+tsepez, who knows (much) more than me about the IPC::Channel internals

[Anand Mistry (off Chromium), 2016-06-03 05:09:33]

On 2016/06/03 04:40:06, dcheng wrote:
> This is just part of the general desire to migrate from IPC::Channel to
> IPC::ChannelMojo right?

Yup. This is an easy one, so might as well get it out of the way.

> Is there anything particular to know about IPC::ChannelMojo in terms of
> differences?

Functionally, no. ChannelMojo does everything the normal IPC::Channels do,
including attachments.

> Obviously it supports Mojo. There's a bit of a performance cost as
> well, right?

Yup.

> Anything else to be aware of?

ChannelMojo is being used for all browser<->renderer communication on all
platforms. I don't see other process types (aside from NaCl) being different.

> 
> +tsepez, who knows (much) more than me about the IPC::Channel internals

[Tom Sepez, 2016-06-03 17:36:00]

This should be ok, give that CreateChanelMojo should return an unforgeable
token.

[Tom Sepez, 2016-06-03 17:37:48]

On 2016/06/03 17:36:00, Tom Sepez wrote:
> This should be ok, give that CreateChanelMojo should return an unforgeable
> token.

Oddly, CS doesn't show any hits for that.  I wanted to double-check...

[ncarter (slow), 2016-06-03 20:18:20]

lgtm

I support this conversion to ChannelMojo.

[Anand Mistry (off Chromium), 2016-06-04 00:08:15]

On 2016/06/03 17:37:48, Tom Sepez wrote:
> On 2016/06/03 17:36:00, Tom Sepez wrote:
> > This should be ok, give that CreateChanelMojo should return an unforgeable
> > token.
> 
> Oddly, CS doesn't show any hits for that.  I wanted to double-check...

Unsubmitted dependent CL: https://codereview.chromium.org/1959313002

[Tom Sepez, 2016-06-06 16:20:25]

lgtm

[Anand Mistry (off Chromium), 2016-06-07 22:37:23]

The CQ bit was checked by amistry@chromium.org

[Anand Mistry (off Chromium), 2016-06-07 22:37:24]

The patchset sent to the CQ was uploaded after l-g-t-m from nick@chromium.org
Link to the patchset: https://codereview.chromium.org/2021103004/#ps40001
(title: "rebase update")

[commit-bot: I haz the power, 2016-06-07 22:37:57]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2021103004/40001

[commit-bot: I haz the power, 2016-06-07 23:53:37]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-06-07 23:54:49]

Description was changed from

==========
Use ChannelMojo for pepper plugin processes.

BUG=604282
==========

to

==========
Use ChannelMojo for pepper plugin processes.

BUG=604282

Committed: https://crrev.com/80ce6dc508ddba8c32c4b5f958bc558b32c427d6
Cr-Commit-Position: refs/heads/master@{#398420}
==========

[commit-bot: I haz the power, 2016-06-07 23:54:50]

Patchset 3 (id:??) landed as
https://crrev.com/80ce6dc508ddba8c32c4b5f958bc558b32c427d6
Cr-Commit-Position: refs/heads/master@{#398420}